Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: content/test/gpu/page_sets/gpu_process_tests.py

Issue 2378473002: Stop passing browser command line args for no_gpu_process on Android. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/page_sets/gpu_process_tests.py
diff --git a/content/test/gpu/page_sets/gpu_process_tests.py b/content/test/gpu/page_sets/gpu_process_tests.py
index 80eaf3f9f05473f6ef8e415e7486ca43c70b29f6..fcf2f930be476860fc97f2d7605a6df482713773 100644
--- a/content/test/gpu/page_sets/gpu_process_tests.py
+++ b/content/test/gpu/page_sets/gpu_process_tests.py
@@ -217,9 +217,13 @@ class NoGpuProcessSharedPageState(GpuProcessSharedPageState):
options = finder_options.browser_options
if options.browser_type.startswith('android'):
- # Hit id 8 from kSoftwareRenderingListJson, which applies to any platform.
- options.AppendExtraBrowserArgs('--gpu-testing-vendor-id=0x10de')
- options.AppendExtraBrowserArgs('--gpu-testing-device-id=0x0324')
+ # Android doesn't support starting up the browser without any
+ # GPU process. This test is skipped on Android in
+ # gpu_process_expectations.py, but we must at least be able to
+ # bring up the browser in order to detect that the test
+ # shouldn't run. Faking a vendor and device ID can get the
+ # browser into a state where it won't launch.
+ pass
elif sys.platform in ('cygwin', 'win32'):
# Hit id 34 from kSoftwareRenderingListJson.
options.AppendExtraBrowserArgs('--gpu-testing-vendor-id=0x5333')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698