Fix MSE ADTS parsing on Android.

Fix MSE ADTS parsing on Android.

Android needs the extra_data fields in order to playback ADTS content,
so fill them in only on Android.

BUG=610848, 650735
TEST=http://storage.googleapis.com/chcunningham-chrome-shared/534301/aac_test.html

Committed: https://crrev.com/b7f5facc5a9b7c6d04206a413c88dbafade336c1
Cr-Commit-Position: refs/heads/master@{#421913}

[DaleCurtis, 2016-09-27 19:38:22]

dalecurtis@chromium.org changed reviewers:
+ chcunningham@chromium.org

[DaleCurtis, 2016-09-28 17:43:10]

Description was changed from

==========
Fix MSE ADTS parsing on Android.

Android needs the extra_data fields in order to playback ADTS content,
so fill them in only on Android.

BUG=650735
TEST=http://storage.googleapis.com/chcunningham-chrome-shared/534301/aac_test.html
==========

to

==========
Fix MSE ADTS parsing on Android.

Android needs the extra_data fields in order to playback ADTS content,
so fill them in only on Android.

BUG=610848, 650735
TEST=http://storage.googleapis.com/chcunningham-chrome-shared/534301/aac_test.html
==========

[chcunningham, 2016-09-28 18:50:00]

Can you also remove the parser call in this test:
https://cs.chromium.org/chromium/src/media/filters/audio_decoder_unittest.cc?...

and instead make it an ASSERT for extra_data being there on Android?

https://codereview.chromium.org/2378443002/diff/1/media/formats/mpeg/adts_str...
File media/formats/mpeg/adts_stream_parser.cc (right):

https://codereview.chromium.org/2378443002/diff/1/media/formats/mpeg/adts_str...
media/formats/mpeg/adts_stream_parser.cc:23: int
ADTSStreamParser::ParseFrameHeader(const uint8_t* data,
I think we have an opportunity to de-dupe the code in:
https://cs.chromium.org/chromium/src/media/formats/mpeg/adts_header_parser.cc...

I think I prefer the way its written below, so I would opt to remove the logic
in adts_header_parser and have it call this method.

[DaleCurtis, 2016-09-29 01:21:41]

Patchset #2 (id:20001) has been deleted

[DaleCurtis, 2016-09-29 01:23:53]

PTAL.

https://codereview.chromium.org/2378443002/diff/1/media/formats/mpeg/adts_str...
File media/formats/mpeg/adts_stream_parser.cc (right):

https://codereview.chromium.org/2378443002/diff/1/media/formats/mpeg/adts_str...
media/formats/mpeg/adts_stream_parser.cc:23: int
ADTSStreamParser::ParseFrameHeader(const uint8_t* data,
On 2016/09/28 at 18:50:00, chcunningham wrote:
> I think we have an opportunity to de-dupe the code in:
>
https://cs.chromium.org/chromium/src/media/formats/mpeg/adts_header_parser.cc...
> 
> I think I prefer the way its written below, so I would opt to remove the logic
in adts_header_parser and have it call this method.

Thanks for pointing that out. I had forgotten about that code. Deleted that file
and callers now use this code directly.

[DaleCurtis, 2016-09-29 01:24:00]

The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 01:24:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 03:00:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 03:00:04]

Dry run: This issue passed the CQ dry run.

[chcunningham, 2016-09-29 20:01:06]

The CQ bit was checked by chcunningham@chromium.org

[chcunningham, 2016-09-29 20:01:07]

lgtm

[commit-bot: I haz the power, 2016-09-29 20:02:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 20:07:17]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-29 20:10:43]

Description was changed from

==========
Fix MSE ADTS parsing on Android.

Android needs the extra_data fields in order to playback ADTS content,
so fill them in only on Android.

BUG=610848, 650735
TEST=http://storage.googleapis.com/chcunningham-chrome-shared/534301/aac_test.html
==========

to

==========
Fix MSE ADTS parsing on Android.

Android needs the extra_data fields in order to playback ADTS content,
so fill them in only on Android.

BUG=610848, 650735
TEST=http://storage.googleapis.com/chcunningham-chrome-shared/534301/aac_test.html

Committed: https://crrev.com/b7f5facc5a9b7c6d04206a413c88dbafade336c1
Cr-Commit-Position: refs/heads/master@{#421913}
==========

[commit-bot: I haz the power, 2016-09-29 20:10:44]

Patchset 2 (id:??) landed as
https://crrev.com/b7f5facc5a9b7c6d04206a413c88dbafade336c1
Cr-Commit-Position: refs/heads/master@{#421913}