media/formats/mpeg/mpeg1_audio_stream_parser.h - Issue 2378443002: Fix MSE ADTS parsing on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mpeg/mpeg1_audio_stream_parser.h

Issue 2378443002: Fix MSE ADTS parsing on Android. (Closed)

Patch Set: Address comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/mpeg/mpeg1_audio_stream_parser.h

diff --git a/media/formats/mpeg/mpeg1_audio_stream_parser.h b/media/formats/mpeg/mpeg1_audio_stream_parser.h

index 9dd7afd7eb15fc1ebe1eeeb9b6a6a3fc16e45280..fc0ce35dac9fe80827cae66c93be7b3db6e66dfb 100644

--- a/media/formats/mpeg/mpeg1_audio_stream_parser.h

+++ b/media/formats/mpeg/mpeg1_audio_stream_parser.h

@@ -79,7 +79,8 @@ class MEDIA_EXPORT MPEG1AudioStreamParser : public MPEGAudioStreamParserBase {

int* sample_rate,

ChannelLayout* channel_layout,

int* sample_count,

- bool* metadata_frame) const override;

+ bool* metadata_frame,

+ std::vector<uint8_t>* extra_data) const override;

DISALLOW_COPY_AND_ASSIGN(MPEG1AudioStreamParser);

};