media/formats/mpeg/mpeg_audio_stream_parser_base.h - Issue 2378443002: Fix MSE ADTS parsing on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mpeg/mpeg_audio_stream_parser_base.h

Issue 2378443002: Fix MSE ADTS parsing on Android. (Closed)

Patch Set: Address comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/formats/mpeg/mpeg_audio_stream_parser_base.h

diff --git a/media/formats/mpeg/mpeg_audio_stream_parser_base.h b/media/formats/mpeg/mpeg_audio_stream_parser_base.h

index cd7fd74d720efb06dfea84cf64955dce25f9d00f..febd814efed26224bbf42d94298b69fd4ea2a0f2 100644

--- a/media/formats/mpeg/mpeg_audio_stream_parser_base.h

+++ b/media/formats/mpeg/mpeg_audio_stream_parser_base.h

@@ -82,7 +82,8 @@ class MEDIA_EXPORT MPEGAudioStreamParserBase : public StreamParser {

int* sample_rate,

ChannelLayout* channel_layout,

int* sample_count,

- bool* metadata_frame) const = 0;

+ bool* metadata_frame,

+ std::vector<uint8_t>* extra_data) const = 0;

const scoped_refptr<MediaLog>& media_log() const { return media_log_; }