Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: content/common/frame_messages.h

Issue 2378393002: Pass the user_gesture context in the IPC message FrameMsg_CommitNavigation to the renderer. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index b9520d9ae87df077d5cedaa5df0eb4ec34f66509..bb17bffd88e03b57287c90aeeaf133df8ca7a563 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -896,11 +896,12 @@ IPC_MESSAGE_ROUTED2(FrameMsg_SelectPopupMenuItems,
// Tells the renderer that a navigation is ready to commit. The renderer should
// request |stream_url| to get access to the stream containing the body of the
// response.
-IPC_MESSAGE_ROUTED4(FrameMsg_CommitNavigation,
+IPC_MESSAGE_ROUTED5(FrameMsg_CommitNavigation,
content::ResourceResponseHead, /* response */
GURL, /* stream_url */
content::CommonNavigationParams, /* common_params */
- content::RequestNavigationParams) /* request_params */
+ content::RequestNavigationParams, /* request_params */
jam 2016/09/29 19:51:38 per the comment in https://cs.chromium.org/chromiu
ananta 2016/09/29 21:28:43 This parameter is not used by non PlzNavigate at t
jam 2016/09/29 21:38:27 StartNavigationParams is what's used for non-plzna
+ bool) /* user_gesture */
// PlzNavigate
// Tells the renderer that a navigation failed with the error code |error_code|
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698