Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2378393002: Pass the user_gesture context in the IPC message FrameMsg_CommitNavigation to the renderer. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index ade16ba1826e7d0dcfc125c7fbceaae55a57be40..828fa59850dcbbd2d7dca24155a685625661629d 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -2310,7 +2310,7 @@ void RenderFrameHostImpl::NavigateToInterstitialURL(const GURL& data_url) {
base::TimeTicks::Now(), "GET", nullptr);
if (IsBrowserSideNavigationEnabled()) {
CommitNavigation(nullptr, nullptr, common_params, RequestNavigationParams(),
- false);
+ false, false);
} else {
Navigate(common_params, StartNavigationParams(), RequestNavigationParams());
}
@@ -2464,7 +2464,8 @@ void RenderFrameHostImpl::CommitNavigation(
std::unique_ptr<StreamHandle> body,
const CommonNavigationParams& common_params,
const RequestNavigationParams& request_params,
- bool is_view_source) {
+ bool is_view_source,
+ bool user_gesture) {
DCHECK((response && body.get()) ||
common_params.url.SchemeIs(url::kDataScheme) ||
!ShouldMakeNetworkRequestForURL(common_params.url));
@@ -2486,7 +2487,7 @@ void RenderFrameHostImpl::CommitNavigation(
const ResourceResponseHead head = response ?
response->head : ResourceResponseHead();
Send(new FrameMsg_CommitNavigation(routing_id_, head, body_url, common_params,
- request_params));
+ request_params, user_gesture));
// If a network request was made, update the LoFi state.
if (ShouldMakeNetworkRequestForURL(common_params.url))

Powered by Google App Engine
This is Rietveld 408576698