Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: content/common/frame_messages.h

Issue 2378393002: Pass the user_gesture context in the IPC message FrameMsg_CommitNavigation to the renderer. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // IPC messages for interacting with frames. 5 // IPC messages for interacting with frames.
6 // Multiply-included message file, hence no include guard. 6 // Multiply-included message file, hence no include guard.
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 878 matching lines...) Expand 10 before | Expand all | Expand 10 after
889 IPC_MESSAGE_ROUTED2(FrameMsg_SelectPopupMenuItems, 889 IPC_MESSAGE_ROUTED2(FrameMsg_SelectPopupMenuItems,
890 bool /* user canceled the popup */, 890 bool /* user canceled the popup */,
891 std::vector<int> /* selected indices */) 891 std::vector<int> /* selected indices */)
892 #endif 892 #endif
893 #endif 893 #endif
894 894
895 // PlzNavigate 895 // PlzNavigate
896 // Tells the renderer that a navigation is ready to commit. The renderer should 896 // Tells the renderer that a navigation is ready to commit. The renderer should
897 // request |stream_url| to get access to the stream containing the body of the 897 // request |stream_url| to get access to the stream containing the body of the
898 // response. 898 // response.
899 IPC_MESSAGE_ROUTED4(FrameMsg_CommitNavigation, 899 IPC_MESSAGE_ROUTED5(FrameMsg_CommitNavigation,
900 content::ResourceResponseHead, /* response */ 900 content::ResourceResponseHead, /* response */
901 GURL, /* stream_url */ 901 GURL, /* stream_url */
902 content::CommonNavigationParams, /* common_params */ 902 content::CommonNavigationParams, /* common_params */
903 content::RequestNavigationParams) /* request_params */ 903 content::RequestNavigationParams, /* request_params */
jam 2016/09/29 19:51:38 per the comment in https://cs.chromium.org/chromiu
ananta 2016/09/29 21:28:43 This parameter is not used by non PlzNavigate at t
jam 2016/09/29 21:38:27 StartNavigationParams is what's used for non-plzna
904 bool) /* user_gesture */
904 905
905 // PlzNavigate 906 // PlzNavigate
906 // Tells the renderer that a navigation failed with the error code |error_code| 907 // Tells the renderer that a navigation failed with the error code |error_code|
907 // and that the renderer should display an appropriate error page. 908 // and that the renderer should display an appropriate error page.
908 IPC_MESSAGE_ROUTED4(FrameMsg_FailedNavigation, 909 IPC_MESSAGE_ROUTED4(FrameMsg_FailedNavigation,
909 content::CommonNavigationParams, /* common_params */ 910 content::CommonNavigationParams, /* common_params */
910 content::RequestNavigationParams, /* request_params */ 911 content::RequestNavigationParams, /* request_params */
911 bool, /* stale_copy_in_cache */ 912 bool, /* stale_copy_in_cache */
912 int /* error_code */) 913 int /* error_code */)
913 914
(...skipping 656 matching lines...) Expand 10 before | Expand all | Expand 10 after
1570 // nearest find result in the sending frame. 1571 // nearest find result in the sending frame.
1571 IPC_MESSAGE_ROUTED2(FrameHostMsg_GetNearestFindResult_Reply, 1572 IPC_MESSAGE_ROUTED2(FrameHostMsg_GetNearestFindResult_Reply,
1572 int /* nfr_request_id */, 1573 int /* nfr_request_id */,
1573 float /* distance */) 1574 float /* distance */)
1574 #endif 1575 #endif
1575 1576
1576 // Adding a new message? Stick to the sort order above: first platform 1577 // Adding a new message? Stick to the sort order above: first platform
1577 // independent FrameMsg, then ifdefs for platform specific FrameMsg, then 1578 // independent FrameMsg, then ifdefs for platform specific FrameMsg, then
1578 // platform independent FrameHostMsg, then ifdefs for platform specific 1579 // platform independent FrameHostMsg, then ifdefs for platform specific
1579 // FrameHostMsg. 1580 // FrameHostMsg.
OLDNEW
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698