Enable ANGLE workaround for unused std140/shared blocks bug

Enable ANGLE workaround for unused std140/shared blocks bug

Active Uniforms/Blocks number is wrong on Mac Drivers when there are
unused std140/shared uniform blocks. The workaround is to insert statements
to reference all members in unused std140/shared blocks at the beginning of
the vertex/fragment shader's main().

BUG=618464
TEST=UniformBufferTest.ActiveUniformBlockNumber
     deqp/functional/gles3/uniformbuffers/random.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/79a5c76ce73c9d7dd4ce4576767660c11b80a382
Cr-Commit-Position: refs/heads/master@{#425740}

[jiajia.qin, 2016-09-29 06:51:42]

Description was changed from

==========
Enable ANGLE workaround for unused std140/shared blocks bug

Active Uniforms/Blocks number is wrong on Mac Drivers when there are
unused std140/shared uniform blocks. The workaround is to insert statements
to reference all members in unused std140/shared blocks at the beginning of
the vertex/fragment shader's main().

BUG=618464
TEST=UniformBufferTest.ActiveUniformBlockNumber
==========

to

==========
Enable ANGLE workaround for unused std140/shared blocks bug

Active Uniforms/Blocks number is wrong on Mac Drivers when there are
unused std140/shared uniform blocks. The workaround is to insert statements
to reference all members in unused std140/shared blocks at the beginning of
the vertex/fragment shader's main().

BUG=618464
TEST=UniformBufferTest.ActiveUniformBlockNumber
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jiajia.qin, 2016-09-29 06:51:43]

Description was changed from

==========
Enable ANGLE workaround for unused std140/shared blocks bug

Active Uniforms/Blocks number is wrong on Mac Drivers when there are
unused std140/shared uniform blocks. The workaround is to insert statements
to reference all members in unused std140/shared blocks at the beginning of
the vertex/fragment shader's main().

BUG=618464
TEST=UniformBufferTest.ActiveUniformBlockNumber
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Enable ANGLE workaround for unused std140/shared blocks bug

Active Uniforms/Blocks number is wrong on Mac Drivers when there are
unused std140/shared uniform blocks. The workaround is to insert statements
to reference all members in unused std140/shared blocks at the beginning of
the vertex/fragment shader's main().

BUG=618464
TEST=UniformBufferTest.ActiveUniformBlockNumber
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[jiajia.qin, 2016-10-14 13:25:01]

Patchset #1 (id:1) has been deleted

[jiajia.qin, 2016-10-14 13:25:12]

Patchset #1 (id:20001) has been deleted

[jiajia.qin, 2016-10-14 13:26:22]

Description was changed from

==========
Enable ANGLE workaround for unused std140/shared blocks bug

Active Uniforms/Blocks number is wrong on Mac Drivers when there are
unused std140/shared uniform blocks. The workaround is to insert statements
to reference all members in unused std140/shared blocks at the beginning of
the vertex/fragment shader's main().

BUG=618464
TEST=UniformBufferTest.ActiveUniformBlockNumber
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Enable ANGLE workaround for unused std140/shared blocks bug

Active Uniforms/Blocks number is wrong on Mac Drivers when there are
unused std140/shared uniform blocks. The workaround is to insert statements
to reference all members in unused std140/shared blocks at the beginning of
the vertex/fragment shader's main().

BUG=618464
TEST=UniformBufferTest.ActiveUniformBlockNumber
     deqp/functional/gles3/uniformbuffers/random.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[jiajia.qin, 2016-10-14 15:16:43]

jiajia.qin@intel.com changed reviewers:
+ cwallez@chromium.org, kbr@chromium.org, zmo@chromium.org

[jiajia.qin, 2016-10-14 15:16:44]

It depends on https://codereview.chromium.org/2421873002/. Please take a look.

[Zhenyao Mo, 2016-10-14 20:43:03]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 20:43:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-14 20:44:59]

Looks good once the nit is fixed (and bots are green)

https://codereview.chromium.org/2378373003/diff/40001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_workaround_type.h (right):

https://codereview.chromium.org/2378373003/diff/40001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_workaround_type.h:182:
GPU_OP(USE_UNUSED_STANDARD_SHARED_BLOCKS,                  \
This is out of order

[commit-bot: I haz the power, 2016-10-14 21:43:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 21:43:03]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[jiajia.qin, 2016-10-17 07:50:01]

Mo, please take another look. Thanks.

https://codereview.chromium.org/2378373003/diff/40001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_workaround_type.h (right):

https://codereview.chromium.org/2378373003/diff/40001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_workaround_type.h:182:
GPU_OP(USE_UNUSED_STANDARD_SHARED_BLOCKS,                  \
On 2016/10/14 20:44:59, Zhenyao Mo wrote:
> This is out of order

Done.

[Corentin Wallez, 2016-10-17 13:45:37]

On 2016/10/17 at 07:50:01, jiajia.qin wrote:
> Mo, please take another look. Thanks.
> 
>
https://codereview.chromium.org/2378373003/diff/40001/gpu/config/gpu_driver_b...
> File gpu/config/gpu_driver_bug_workaround_type.h (right):
> 
>
https://codereview.chromium.org/2378373003/diff/40001/gpu/config/gpu_driver_b...
> gpu/config/gpu_driver_bug_workaround_type.h:182:
GPU_OP(USE_UNUSED_STANDARD_SHARED_BLOCKS,                  \
> On 2016/10/14 20:44:59, Zhenyao Mo wrote:
> > This is out of order
> 
> Done.

lgtm, I'm not an OWNER though.

[Zhenyao Mo, 2016-10-17 17:54:49]

On 2016/10/17 13:45:37, Corentin Wallez wrote:
> On 2016/10/17 at 07:50:01, jiajia.qin wrote:
> > Mo, please take another look. Thanks.
> > 
> >
>
https://codereview.chromium.org/2378373003/diff/40001/gpu/config/gpu_driver_b...
> > File gpu/config/gpu_driver_bug_workaround_type.h (right):
> > 
> >
>
https://codereview.chromium.org/2378373003/diff/40001/gpu/config/gpu_driver_b...
> > gpu/config/gpu_driver_bug_workaround_type.h:182:
> GPU_OP(USE_UNUSED_STANDARD_SHARED_BLOCKS,                  \
> > On 2016/10/14 20:44:59, Zhenyao Mo wrote:
> > > This is out of order
> > 
> > Done.
> 
> lgtm, I'm not an OWNER though.

lgtm

[Zhenyao Mo, 2016-10-17 17:54:57]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-10-17 17:55:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 19:18:34]

Description was changed from

==========
Enable ANGLE workaround for unused std140/shared blocks bug

Active Uniforms/Blocks number is wrong on Mac Drivers when there are
unused std140/shared uniform blocks. The workaround is to insert statements
to reference all members in unused std140/shared blocks at the beginning of
the vertex/fragment shader's main().

BUG=618464
TEST=UniformBufferTest.ActiveUniformBlockNumber
     deqp/functional/gles3/uniformbuffers/random.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Enable ANGLE workaround for unused std140/shared blocks bug

Active Uniforms/Blocks number is wrong on Mac Drivers when there are
unused std140/shared uniform blocks. The workaround is to insert statements
to reference all members in unused std140/shared blocks at the beginning of
the vertex/fragment shader's main().

BUG=618464
TEST=UniformBufferTest.ActiveUniformBlockNumber
     deqp/functional/gles3/uniformbuffers/random.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-17 19:18:36]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-10-17 19:23:02]

Description was changed from

==========
Enable ANGLE workaround for unused std140/shared blocks bug

Active Uniforms/Blocks number is wrong on Mac Drivers when there are
unused std140/shared uniform blocks. The workaround is to insert statements
to reference all members in unused std140/shared blocks at the beginning of
the vertex/fragment shader's main().

BUG=618464
TEST=UniformBufferTest.ActiveUniformBlockNumber
     deqp/functional/gles3/uniformbuffers/random.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Enable ANGLE workaround for unused std140/shared blocks bug

Active Uniforms/Blocks number is wrong on Mac Drivers when there are
unused std140/shared uniform blocks. The workaround is to insert statements
to reference all members in unused std140/shared blocks at the beginning of
the vertex/fragment shader's main().

BUG=618464
TEST=UniformBufferTest.ActiveUniformBlockNumber
     deqp/functional/gles3/uniformbuffers/random.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/79a5c76ce73c9d7dd4ce4576767660c11b80a382
Cr-Commit-Position: refs/heads/master@{#425740}
==========

[commit-bot: I haz the power, 2016-10-17 19:23:03]

Patchset 3 (id:??) landed as
https://crrev.com/79a5c76ce73c9d7dd4ce4576767660c11b80a382
Cr-Commit-Position: refs/heads/master@{#425740}