MD Settings: Search page, switching paper-dropdown-menu to native select.

MD Settings: Search page, switching paper-dropdown-menu to native select.

BUG=651513, 640496
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b5c369c4b3fe3b1b9a3f710c39ae7ea67b56eb5d
Cr-Commit-Position: refs/heads/master@{#421976}

[dpapad, 2016-09-29 00:32:22]

Description was changed from

==========
MD Settings: Switching paper-dropdown-menu to native select, part 1.

BUG=
==========

to

==========
MD Settings: Switching paper-dropdown-menu to native select, part 1.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-09-29 00:41:03]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-09-29 18:40:34]

Description was changed from

==========
MD Settings: Switching paper-dropdown-menu to native select, part 1.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Search page, switching paper-dropdown-menu to native select.

BUG=651513, 640496
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-09-29 18:57:59]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 18:58:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-09-29 19:08:32]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-09-29 19:16:23]

https://codereview.chromium.org/2378253003/diff/70001/chrome/browser/resource...
File chrome/browser/resources/settings/search_page/search_page.html (right):

https://codereview.chromium.org/2378253003/diff/70001/chrome/browser/resource...
chrome/browser/resources/settings/search_page/search_page.html:22: <option
class="dropdown-item" role="option" selected$="[[item.default]]">
We can probably remove both the class and the role now. I believe that the class
was only used for styling and the role should just work given the existence of
<option>

[dpapad, 2016-09-29 20:27:30]

On 2016/09/29 at 19:16:23, dpapad wrote:
>
https://codereview.chromium.org/2378253003/diff/70001/chrome/browser/resource...
> File chrome/browser/resources/settings/search_page/search_page.html (right):
> 
>
https://codereview.chromium.org/2378253003/diff/70001/chrome/browser/resource...
> chrome/browser/resources/settings/search_page/search_page.html:22: <option
class="dropdown-item" role="option" selected$="[[item.default]]">
> We can probably remove both the class and the role now. I believe that the
class was only used for styling and the role should just work given the
existence of <option>

Done.

[dpapad, 2016-09-29 22:32:19]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 22:32:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-09-29 23:04:19]

this looks super duper

lgtm

[dpapad, 2016-09-29 23:13:51]

On 2016/09/29 at 23:04:19, dbeam wrote:
> this looks super duper
> 
> lgtm

Thanks!

[dpapad, 2016-09-29 23:14:01]

The CQ bit was unchecked by dpapad@chromium.org

[dpapad, 2016-09-29 23:14:03]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-09-29 23:14:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 23:23:16]

Committed patchset #6 (id:110001)

[commit-bot: I haz the power, 2016-09-29 23:25:48]

Description was changed from

==========
MD Settings: Search page, switching paper-dropdown-menu to native select.

BUG=651513, 640496
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Search page, switching paper-dropdown-menu to native select.

BUG=651513, 640496
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b5c369c4b3fe3b1b9a3f710c39ae7ea67b56eb5d
Cr-Commit-Position: refs/heads/master@{#421976}
==========

[commit-bot: I haz the power, 2016-09-29 23:25:49]

Patchset 6 (id:??) landed as
https://crrev.com/b5c369c4b3fe3b1b9a3f710c39ae7ea67b56eb5d
Cr-Commit-Position: refs/heads/master@{#421976}