Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2378253003: MD Settings: Search page, switching paper-dropdown-menu to native select. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Search page, switching paper-dropdown-menu to native select. BUG=651513, 640496 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b5c369c4b3fe3b1b9a3f710c39ae7ea67b56eb5d Cr-Commit-Position: refs/heads/master@{#421976}

Patch Set 1 : Nit. #

Patch Set 2 : Nit. #

Patch Set 3 : Updating test. #

Patch Set 4 : Nits. #

Total comments: 1

Patch Set 5 : Remove more. #

Patch Set 6 : Merge conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -38 lines) Patch
M chrome/browser/resources/settings/search_page/search_page.html View 1 2 3 4 5 1 chunk +8 lines, -12 lines 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.js View 1 2 3 1 chunk +3 lines, -21 lines 0 comments Download
A chrome/browser/resources/settings/select_css.html View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/search_page_test.js View 1 2 2 chunks +8 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
dpapad
4 years, 2 months ago (2016-09-29 19:08:33 UTC) #7
dpapad
https://codereview.chromium.org/2378253003/diff/70001/chrome/browser/resources/settings/search_page/search_page.html File chrome/browser/resources/settings/search_page/search_page.html (right): https://codereview.chromium.org/2378253003/diff/70001/chrome/browser/resources/settings/search_page/search_page.html#newcode22 chrome/browser/resources/settings/search_page/search_page.html:22: <option class="dropdown-item" role="option" selected$="[[item.default]]"> We can probably remove both ...
4 years, 2 months ago (2016-09-29 19:16:23 UTC) #8
dpapad
On 2016/09/29 at 19:16:23, dpapad wrote: > https://codereview.chromium.org/2378253003/diff/70001/chrome/browser/resources/settings/search_page/search_page.html > File chrome/browser/resources/settings/search_page/search_page.html (right): > > https://codereview.chromium.org/2378253003/diff/70001/chrome/browser/resources/settings/search_page/search_page.html#newcode22 ...
4 years, 2 months ago (2016-09-29 20:27:30 UTC) #9
Dan Beam
this looks super duper lgtm
4 years, 2 months ago (2016-09-29 23:04:19 UTC) #12
dpapad
On 2016/09/29 at 23:04:19, dbeam wrote: > this looks super duper > > lgtm Thanks!
4 years, 2 months ago (2016-09-29 23:13:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378253003/110001
4 years, 2 months ago (2016-09-29 23:14:13 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:110001)
4 years, 2 months ago (2016-09-29 23:23:16 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 23:25:49 UTC) #19
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/b5c369c4b3fe3b1b9a3f710c39ae7ea67b56eb5d
Cr-Commit-Position: refs/heads/master@{#421976}

Powered by Google App Engine
This is Rietveld 408576698