Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 2378253003: MD Settings: Search page, switching paper-dropdown-menu to native select. (Closed)
Patch Set: Nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/search_page/search_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu-light.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-lis tbox.html">
6 <link rel="import" href="/route.html"> 4 <link rel="import" href="/route.html">
7 <link rel="import" href="/search_engines_page/search_engines_page.html"> 5 <link rel="import" href="/search_engines_page/search_engines_page.html">
8 <link rel="import" href="/search_engines_page/search_engines_browser_proxy.html" > 6 <link rel="import" href="/search_engines_page/search_engines_browser_proxy.html" >
9 <link rel="import" href="/settings_page/settings_animated_pages.html"> 7 <link rel="import" href="/settings_page/settings_animated_pages.html">
10 <link rel="import" href="/settings_page/settings_subpage.html"> 8 <link rel="import" href="/settings_page/settings_subpage.html">
11 <link rel="import" href="/settings_shared_css.html"> 9 <link rel="import" href="/settings_shared_css.html">
10 <link rel="import" href="/select_css.html">
12 11
13 <dom-module id="settings-search-page"> 12 <dom-module id="settings-search-page">
14 <template> 13 <template>
15 <style include="settings-shared"> 14 <style include="settings-shared select"></style>
16 </style>
17 <settings-animated-pages id="pages" section="search"> 15 <settings-animated-pages id="pages" section="search">
18 <neon-animatable route-path="default"> 16 <neon-animatable route-path="default">
19 <div class="settings-box first"> 17 <div class="settings-box first">
20 <p class="start">$i18n{searchExplanation}</p> 18 <p class="start">$i18n{searchExplanation}</p>
21 <paper-dropdown-menu-light vertical-align="auto" no-label-float> 19 <div>
22 <paper-listbox class="dropdown-content" 20 <select on-change="onChange_">
23 selected="[[getSelectedSearchEngineIndex_(searchEngines_)]]"
24 on-iron-select="onIronSelect_">
25 <template is="dom-repeat" items="[[searchEngines_]]"> 21 <template is="dom-repeat" items="[[searchEngines_]]">
26 <button class="dropdown-item" role="option"> 22 <option class="dropdown-item" role="option" selected$="[[item.de fault]]">
dpapad 2016/09/29 19:16:23 We can probably remove both the class and the role
27 [[item.name]] 23 [[item.name]]
28 </button> 24 </option>
29 </template> 25 </template>
30 </paper-listbox> 26 </select>
31 </paper-dropdown-menu-light> 27 <span class="select-underline"></span>
28 </div>
32 </div> 29 </div>
33 <div id="subpage-trigger" class="settings-box"> 30 <div id="subpage-trigger" class="settings-box">
34 <paper-button on-tap="onManageSearchEnginesTap_" 31 <paper-button on-tap="onManageSearchEnginesTap_"
35 class="primary-button"> 32 class="primary-button">
36 $i18n{searchEnginesManage} 33 $i18n{searchEnginesManage}
37 </paper-button> 34 </paper-button>
38 </div> 35 </div>
39 </neon-animatable> 36 </neon-animatable>
40 <template is="dom-if" route-path="/searchEngines"> 37 <template is="dom-if" route-path="/searchEngines">
41 <settings-subpage 38 <settings-subpage
42 associated-control="[[$$('#subpage-trigger')]]" 39 associated-control="[[$$('#subpage-trigger')]]"
43 page-title="$i18n{searchEnginesManage}"> 40 page-title="$i18n{searchEnginesManage}">
44 <settings-search-engines-page></settings-search-engines-page> 41 <settings-search-engines-page></settings-search-engines-page>
45 </settings-subpage> 42 </settings-subpage>
46 </template> 43 </template>
47 </settings-animated-pages> 44 </settings-animated-pages>
48 </template> 45 </template>
49 <script src="search_page.js"></script> 46 <script src="search_page.js"></script>
50 </dom-module> 47 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/search_page/search_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698