Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2383513003: MD Settings: Migrating add/edit credit card dropdowns to native select. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Migrating add/edit credit card dropdowns to native select. BUG=651513 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/fa522478814cd467fd68c534d2e07c99cbd75be8 Cr-Commit-Position: refs/heads/master@{#422594}

Patch Set 1 : Resolve conflicts #

Patch Set 2 : Fixing test. #

Patch Set 3 : Nit. #

Total comments: 4

Patch Set 4 : Rebase #

Total comments: 6

Patch Set 5 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -80 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html View 1 2 3 4 2 chunks +29 lines, -32 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js View 1 2 3 4 3 chunks +23 lines, -6 lines 0 comments Download
M chrome/test/data/webui/settings/settings_autofill_section_browsertest.js View 1 2 3 4 6 chunks +66 lines, -42 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (18 generated)
dpapad
See before/after screenshots at http://imgur.com/a/gs4ML. Tests are on patch2 (expecting all green).
4 years, 2 months ago (2016-09-29 23:24:57 UTC) #16
dpapad
On 2016/09/29 at 23:24:57, dpapad wrote: > See before/after screenshots at http://imgur.com/a/gs4ML. Tests are on ...
4 years, 2 months ago (2016-10-03 17:22:10 UTC) #17
Dan Beam
https://codereview.chromium.org/2383513003/diff/80001/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html File chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html (right): https://codereview.chromium.org/2383513003/diff/80001/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html#newcode10 chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html:10: <style include="settings-shared select"> might be useful to eventually rename ...
4 years, 2 months ago (2016-10-03 18:24:48 UTC) #18
dpapad
Addressed comments. PTAL https://codereview.chromium.org/2383513003/diff/80001/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html File chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html (right): https://codereview.chromium.org/2383513003/diff/80001/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html#newcode10 chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html:10: <style include="settings-shared select"> On 2016/10/03 at ...
4 years, 2 months ago (2016-10-03 21:37:05 UTC) #20
Dan Beam
lgtm
4 years, 2 months ago (2016-10-03 22:03:50 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383513003/140001
4 years, 2 months ago (2016-10-03 22:17:29 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:140001)
4 years, 2 months ago (2016-10-03 23:26:21 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 23:29:38 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/fa522478814cd467fd68c534d2e07c99cbd75be8
Cr-Commit-Position: refs/heads/master@{#422594}

Powered by Google App Engine
This is Rietveld 408576698