Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2377763003: Revert "Updated to GVR 1.0 SDK" (Closed)

Created:
4 years, 2 months ago by David Trainor- moved to gerrit
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Updated to GVR 1.0 SDK" This reverts commit 80ccce30a1ca124086bae9d46d4b9edbbd7059ba. BUG=389343 TBR=bshe@ Committed: https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95 Cr-Commit-Position: refs/heads/master@{#421352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -492 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/ui_elements.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_gl_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_math.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_math.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 4 chunks +37 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_renderer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/vr/android/gvr/gvr_device.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M device/vr/android/gvr/gvr_device_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/vr/android/gvr/gvr_device_provider.cc View 5 chunks +17 lines, -12 lines 0 comments Download
M device/vr/android/gvr/gvr_gamepad_data_fetcher.h View 2 chunks +2 lines, -3 lines 0 comments Download
M device/vr/android/gvr/gvr_gamepad_data_fetcher.cc View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/gvr-android-sdk/BUILD.gn View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/gvr-android-sdk/LICENSE View 3 chunks +1 line, -447 lines 0 comments Download
M third_party/gvr-android-sdk/README.chromium View 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/gvr-android-sdk/proguard/base.flags View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
David Trainor- moved to gerrit
landing this to fix a release build issue with missing methods from the Android SDK. ...
4 years, 2 months ago (2016-09-27 20:56:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377763003/1
4 years, 2 months ago (2016-09-27 20:56:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 21:59:02 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 22:02:24 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/579759c320d284129d41eda17dfa37702e7bdc95
Cr-Commit-Position: refs/heads/master@{#421352}

Powered by Google App Engine
This is Rietveld 408576698