Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: test/no_packages_dir_test.dart

Issue 2377063002: Make "--no-packages-dir" the default. (Closed)
Patch Set: Revise again. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/implicit_dependency_test.dart ('k') | test/pub_get_and_upgrade_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/no_packages_dir_test.dart
diff --git a/test/no_packages_dir_test.dart b/test/no_packages_dir_test.dart
index 579788e6502165afefa1f51641be614dccee92c3..2e590c187f40911fa26736dacc50999bd5369836 100644
--- a/test/no_packages_dir_test.dart
+++ b/test/no_packages_dir_test.dart
@@ -9,69 +9,7 @@ import 'test_pub.dart';
main() {
forBothPubGetAndUpgrade((command) {
- group("with --no-packages-dir", () {
- integration("installs hosted dependencies to the cache", () {
- servePackages((builder) {
- builder.serve("foo", "1.0.0");
- builder.serve("bar", "1.0.0");
- });
-
- d.appDir({"foo": "any", "bar": "any"}).create();
-
- pubCommand(command, args: ["--no-packages-dir"]);
-
- d.nothing("$appPath/packages").validate();
-
- d.hostedCache([
- d.dir("foo-1.0.0", [
- d.dir("lib", [d.file("foo.dart", 'main() => "foo 1.0.0";')])
- ]),
- d.dir("bar-1.0.0", [
- d.dir("lib", [d.file("bar.dart", 'main() => "bar 1.0.0";')])
- ])
- ]).validate();
- });
-
- integration("installs git dependencies to the cache", () {
- ensureGit();
-
- d.git('foo.git', [
- d.libDir('foo'),
- d.libPubspec('foo', '1.0.0')
- ]).create();
-
- d.appDir({"foo": {"git": "../foo.git"}}).create();
-
- pubCommand(command, args: ["--no-packages-dir"]);
-
- d.nothing("$appPath/packages").validate();
-
- d.dir(cachePath, [
- d.dir('git', [
- d.dir('cache', [d.gitPackageRepoCacheDir('foo')]),
- d.gitPackageRevisionCacheDir('foo')
- ])
- ]).validate();
- });
-
- integration("locks path dependencies", () {
- d.dir("foo", [
- d.libDir("foo"),
- d.libPubspec("foo", "0.0.1")
- ]).create();
-
- d.dir(appPath, [
- d.appPubspec({
- "foo": {"path": "../foo"}
- })
- ]).create();
-
- pubCommand(command, args: ["--no-packages-dir"]);
-
- d.nothing("$appPath/packages").validate();
- d.matcherFile("$appPath/pubspec.lock", contains("foo"));
- });
-
+ group("without --packages-dir", () {
integration("removes package directories near entrypoints", () {
d.dir(appPath, [
d.appPubspec(),
@@ -81,7 +19,7 @@ main() {
d.dir("web/subdir/packages")
]).create();
- pubCommand(command, args: ["--no-packages-dir"]);
+ pubCommand(command);
d.dir(appPath, [
d.nothing("packages"),
@@ -100,7 +38,7 @@ main() {
d.dir("lib/packages")
]).create();
- pubCommand(command, args: ["--no-packages-dir"]);
+ pubCommand(command);
d.dir(appPath, [
d.nothing("packages"),
« no previous file with comments | « test/implicit_dependency_test.dart ('k') | test/pub_get_and_upgrade_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698