Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: test/implicit_dependency_test.dart

Issue 2377063002: Make "--no-packages-dir" the default. (Closed)
Patch Set: Revise again. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/implicit_barback_dependency_test.dart ('k') | test/no_packages_dir_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/implicit_dependency_test.dart
diff --git a/test/implicit_dependency_test.dart b/test/implicit_dependency_test.dart
index 4c779781bbf73a110ce6dd4ea089cf6f05891ad2..000a30e90aeeea49d95ebb903e65c6a923eb5c2c 100644
--- a/test/implicit_dependency_test.dart
+++ b/test/implicit_dependency_test.dart
@@ -27,7 +27,12 @@ main() {
pubCommand(command);
- d.packagesDir({"stack_trace": nextPatch("stack_trace")}).validate();
+ d.appPackagesFile({
+ "async": current("async"),
+ "barback": current("barback"),
+ "source_span": current("source_span"),
+ "stack_trace": nextPatch("stack_trace")
+ }).validate();
});
integration("pub's implicit constraint uses the same source and "
@@ -58,8 +63,11 @@ main() {
// Validate that we're using the path dependency version of stack_trace
// rather than the hosted version.
- d.packagesDir({
- "stack_trace": current("stack_trace")
+ d.appPackagesFile({
+ "async": current("async"),
+ "barback": current("barback"),
+ "source_span": current("source_span"),
+ "stack_trace": "../stack_trace"
}).validate();
});
@@ -80,7 +88,7 @@ main() {
pubCommand(command);
- d.packagesDir({"stack_trace": max("stack_trace")}).validate();
+ d.appPackagesFile({"stack_trace": max("stack_trace")}).validate();
});
});
@@ -105,7 +113,10 @@ main() {
pubGet();
// It should be upgraded.
- d.packagesDir({
+ d.appPackagesFile({
+ "async": current("async"),
+ "barback": current("barback"),
+ "source_span": current("source_span"),
"stack_trace": current("stack_trace")
}).validate();
});
« no previous file with comments | « test/implicit_barback_dependency_test.dart ('k') | test/no_packages_dir_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698