Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: test/pub_get_and_upgrade_test.dart

Issue 2377063002: Make "--no-packages-dir" the default. (Closed)
Patch Set: Revise again. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/no_packages_dir_test.dart ('k') | test/sdk_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/pub_get_and_upgrade_test.dart
diff --git a/test/pub_get_and_upgrade_test.dart b/test/pub_get_and_upgrade_test.dart
index d7c45e244bbe8a9ec98ce0b9299901320d9c2c12..5d1c60160663be3af1bb579d8f6a970d577c8045 100644
--- a/test/pub_get_and_upgrade_test.dart
+++ b/test/pub_get_and_upgrade_test.dart
@@ -30,20 +30,26 @@ main() {
});
});
- integration('adds itself to the packages', () {
- // The symlink should use the name in the pubspec, not the name of the
+ integration('adds itself to the packages directory and .packages file', () {
+ // The package should use the name in the pubspec, not the name of the
// directory.
d.dir(appPath, [
d.pubspec({"name": "myapp_name"}),
d.libDir('myapp_name')
]).create();
- pubCommand(command);
+ pubCommand(command, args: ["--packages-dir"]);
d.dir(packagesPath, [
d.dir("myapp_name", [
d.file('myapp_name.dart', 'main() => "myapp_name";')
])
+ ]).validate();
+
+ d.dir("myapp", [
+ d.packagesFile({
+ "myapp_name": "."
+ })
]).validate();
});
@@ -55,7 +61,7 @@ main() {
d.pubspec({"name": "myapp_name"}),
]).create();
- pubCommand(command);
+ pubCommand(command, args: ["--packages-dir"]);
d.dir(packagesPath, [
d.nothing("myapp_name")
@@ -73,7 +79,7 @@ main() {
d.appPubspec({"foo": {"path": "../foo"}})
]).create();
- pubCommand(command);
+ pubCommand(command, args: ["--packages-dir"]);
d.packagesDir({"foo": null}).validate();
});
« no previous file with comments | « test/no_packages_dir_test.dart ('k') | test/sdk_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698