Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/libaddressinput/chromium/cpp/test/address_validator_test.cc

Issue 237693002: requestAutocomplete should not unlatinize administrative region names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Canonicalize latinized name without unlatinizing it. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/cpp/test/address_validator_test.cc
diff --git a/third_party/libaddressinput/chromium/cpp/test/address_validator_test.cc b/third_party/libaddressinput/chromium/cpp/test/address_validator_test.cc
index f0d2095fffc0ea5246461090c450b9bbc081fa0c..891de35b6c86a4067f53fb1bd33eead841151283 100644
--- a/third_party/libaddressinput/chromium/cpp/test/address_validator_test.cc
+++ b/third_party/libaddressinput/chromium/cpp/test/address_validator_test.cc
@@ -556,5 +556,39 @@ TEST_F(AddressValidatorTest, SuggestOnlyForAdministrativeAreasAndPostalCode) {
}
}
+TEST_F(AddressValidatorTest, CanonicalizeUsAdminAreaName) {
+ AddressData address;
+ address.country_code = "US";
+ address.administrative_area = "cALIFORNIa";
+ EXPECT_TRUE(validator_->CanonicalizeAdministrativeArea(&address));
+ EXPECT_EQ("CA", address.administrative_area);
+}
+
+TEST_F(AddressValidatorTest, CanonicalizeUsAdminAreaKey) {
+ AddressData address;
+ address.country_code = "US";
+ address.administrative_area = "CA";
+ EXPECT_TRUE(validator_->CanonicalizeAdministrativeArea(&address));
+ EXPECT_EQ("CA", address.administrative_area);
+}
+
+TEST_F(AddressValidatorTest, CanonicalizeJpAdminAreaKey) {
+ validator_->LoadRules("JP");
+ AddressData address;
+ address.country_code = "JP";
+ address.administrative_area = "東京都";
+ EXPECT_TRUE(validator_->CanonicalizeAdministrativeArea(&address));
+ EXPECT_EQ("東京都", address.administrative_area);
+}
+
+TEST_F(AddressValidatorTest, CanonicalizeJpAdminAreaLatinName) {
+ validator_->LoadRules("JP");
+ AddressData address;
+ address.country_code = "JP";
+ address.administrative_area = "tOKYo";
+ EXPECT_TRUE(validator_->CanonicalizeAdministrativeArea(&address));
+ EXPECT_EQ("TOKYO", address.administrative_area);
Evan Stade 2014/04/16 21:55:46 -_- Hopefully one day this becomes Tokyo, right?
please use gerrit instead 2014/04/16 22:53:27 lol. i18n team is in process of fixing capitalizat
+}
+
} // namespace addressinput
} // namespace i18n

Powered by Google App Engine
This is Rietveld 408576698