Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: third_party/libaddressinput/chromium/cpp/test/address_validator_test.cc

Issue 237693002: requestAutocomplete should not unlatinize administrative region names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Canonicalize latinized name without unlatinizing it. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (C) 2014 Google Inc. 1 // Copyright (C) 2014 Google Inc.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 538 matching lines...) Expand 10 before | Expand all | Expand 10 after
549 549
550 for (size_t i = 0; i < kNumNoSuggestFields; ++i) { 550 for (size_t i = 0; i < kNumNoSuggestFields; ++i) {
551 std::vector<AddressData> suggestions; 551 std::vector<AddressData> suggestions;
552 EXPECT_EQ(AddressValidator::SUCCESS, 552 EXPECT_EQ(AddressValidator::SUCCESS,
553 validator_->GetSuggestions( 553 validator_->GetSuggestions(
554 address, kNoSugestFields[i], 999, &suggestions)); 554 address, kNoSugestFields[i], 999, &suggestions));
555 EXPECT_TRUE(suggestions.empty()); 555 EXPECT_TRUE(suggestions.empty());
556 } 556 }
557 } 557 }
558 558
559 TEST_F(AddressValidatorTest, CanonicalizeUsAdminAreaName) {
560 AddressData address;
561 address.country_code = "US";
562 address.administrative_area = "cALIFORNIa";
563 EXPECT_TRUE(validator_->CanonicalizeAdministrativeArea(&address));
564 EXPECT_EQ("CA", address.administrative_area);
565 }
566
567 TEST_F(AddressValidatorTest, CanonicalizeUsAdminAreaKey) {
568 AddressData address;
569 address.country_code = "US";
570 address.administrative_area = "CA";
571 EXPECT_TRUE(validator_->CanonicalizeAdministrativeArea(&address));
572 EXPECT_EQ("CA", address.administrative_area);
573 }
574
575 TEST_F(AddressValidatorTest, CanonicalizeJpAdminAreaKey) {
576 validator_->LoadRules("JP");
577 AddressData address;
578 address.country_code = "JP";
579 address.administrative_area = "東京都";
580 EXPECT_TRUE(validator_->CanonicalizeAdministrativeArea(&address));
581 EXPECT_EQ("東京都", address.administrative_area);
582 }
583
584 TEST_F(AddressValidatorTest, CanonicalizeJpAdminAreaLatinName) {
585 validator_->LoadRules("JP");
586 AddressData address;
587 address.country_code = "JP";
588 address.administrative_area = "tOKYo";
589 EXPECT_TRUE(validator_->CanonicalizeAdministrativeArea(&address));
590 EXPECT_EQ("TOKYO", address.administrative_area);
Evan Stade 2014/04/16 21:55:46 -_- Hopefully one day this becomes Tokyo, right?
please use gerrit instead 2014/04/16 22:53:27 lol. i18n team is in process of fixing capitalizat
591 }
592
559 } // namespace addressinput 593 } // namespace addressinput
560 } // namespace i18n 594 } // namespace i18n
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698