third_party/libaddressinput/chromium/cpp/test/rule_test.cc - Issue 237693002: requestAutocomplete should not unlatinize administrative region names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/chromium/cpp/test/rule_test.cc

Issue 237693002: requestAutocomplete should not unlatinize administrative region names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Canonicalize latinized name without unlatinizing it. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/libaddressinput/chromium/cpp/test/address_validator_test.cc ('K') | « third_party/libaddressinput/chromium/cpp/test/address_validator_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/libaddressinput/chromium/cpp/test/rule_test.cc

diff --git a/third_party/libaddressinput/chromium/cpp/test/rule_test.cc b/third_party/libaddressinput/chromium/cpp/test/rule_test.cc

index ae3cfc359427cb2174276d502d7b5b378e5116a3..0b616d47ef30fbdf764ec42ff7a4636a9aad6671 100644

--- a/third_party/libaddressinput/chromium/cpp/test/rule_test.cc

+++ b/third_party/libaddressinput/chromium/cpp/test/rule_test.cc

@@ -329,19 +329,25 @@ TEST(RuleTest, ParseSubKeyTest) {

EXPECT_EQ(3U, rule.GetSubKeys().size());

std::string sub_key;

- EXPECT_TRUE(rule.CanonicalizeSubKey("BAR", &sub_key));

+ EXPECT_TRUE(rule.CanonicalizeSubKey("BAR", true, &sub_key));

EXPECT_EQ("BAR", sub_key);

sub_key.clear();

- EXPECT_TRUE(rule.CanonicalizeSubKey("Bartopolis", &sub_key));

+ EXPECT_TRUE(rule.CanonicalizeSubKey("Bartopolis", true, &sub_key));

EXPECT_EQ("BAR", sub_key);

sub_key.clear();

- EXPECT_TRUE(rule.CanonicalizeSubKey("Bartopolis2", &sub_key));

+ // Unlatinize.

+ EXPECT_TRUE(rule.CanonicalizeSubKey("Bartopolis2", true, &sub_key));

EXPECT_EQ("BAR", sub_key);

sub_key.clear();

- EXPECT_FALSE(rule.CanonicalizeSubKey("Beertopia", &sub_key));

+ // Should not unlatinize.

+ EXPECT_TRUE(rule.CanonicalizeSubKey("Bartopolis2", false, &sub_key));

+ EXPECT_EQ("Bartopolis2", sub_key);

+ sub_key.clear();

+ EXPECT_FALSE(rule.CanonicalizeSubKey("Beertopia", true, &sub_key));

EXPECT_EQ("", sub_key);

}