Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23769011: Move a bunch of windows stuff from ui/base/win to ui/gfx/win (Closed)

Created:
7 years, 3 months ago by Ben Goodger (Google)
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, weitaosu+watch_chromium.org, nkostylev+watch_chromium.org, amit, dcheng, sievers+watch_chromium.org, joi+watch-content_chromium.org, sadrul, Ilya Sherman, yusukes+watch_chromium.org, extensions-reviews_chromium.org, jar (doing other things), ben+watch_chromium.org, stevenjb+watch_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org, derat+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, sanjeevr, penghuang+watch_chromium.org, rmsousa+watch_chromium.org, asvitkine+watch_chromium.org, piman+watch_chromium.org, sergeyu+watch_chromium.org, alexeypa+watch_chromium.org, jochen+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, oshima+watch_chromium.org, Ian Vollick, tfarina, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, jshin+watch_chromium.org, danakj+watch_chromium.org, James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move a bunch of windows stuff from ui/base/win to ui/gfx/win R=sky@chromium.org BUG=103304 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222860

Patch Set 1 #

Patch Set 2 : Fix bustage & rebase #

Patch Set 3 : Fix bustage #

Patch Set 4 : . #

Patch Set 5 : rebase #

Patch Set 6 : Moar bustage. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -1435 lines) Patch
M chrome/browser/about_flags.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/system_display/display_info_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/hang_monitor/hung_plugin_action.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_menu_button_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_desktop_root_window_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/minimize_button_metrics_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/simple_message_box_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/app/content_main_runner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 7 chunks +9 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_contents_view_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell_win.cc View 1 2 3 6 chunks +8 lines, -8 lines 0 comments Download
M remoting/host/plugin/host_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/memory_watcher/hotkey.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/root_window_host_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_win.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/l10n/l10n_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/layout.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/base/text/utf16_indexing.h View 1 chunk +0 lines, -49 lines 0 comments Download
D ui/base/text/utf16_indexing.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D ui/base/text/utf16_indexing_unittest.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/ui_base_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/base/win/events_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/win/foreground_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/win/foreground_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/win/hidden_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/win/hwnd_subclass.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/win/hwnd_subclass_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D ui/base/win/hwnd_util.h View 1 chunk +0 lines, -57 lines 0 comments Download
D ui/base/win/hwnd_util.cc View 1 chunk +0 lines, -214 lines 0 comments Download
M ui/base/win/mouse_wheel_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
D ui/base/win/scoped_set_map_mode.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/base/win/singleton_hwnd.h View 1 chunk +0 lines, -61 lines 0 comments Download
D ui/base/win/singleton_hwnd.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D ui/base/win/window_impl.h View 1 chunk +0 lines, -123 lines 0 comments Download
D ui/base/win/window_impl.cc View 1 1 chunk +0 lines, -273 lines 0 comments Download
M ui/compositor/test/test_compositor_host_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas_paint_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/display.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/gfx/dpi_win.h View 1 chunk +0 lines, -63 lines 0 comments Download
D ui/gfx/dpi_win.cc View 1 chunk +0 lines, -175 lines 0 comments Download
M ui/gfx/font_smoothing_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/platform_font_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/render_text.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/render_text_linux.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ui/gfx/render_text_win.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M ui/gfx/screen_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/switches.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/switches.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/sys_color_change_listener.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/utf16_indexing.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + ui/gfx/utf16_indexing.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/utf16_indexing_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/win/dpi.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/win/dpi.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/win/hwnd_util.h View 2 chunks +5 lines, -8 lines 0 comments Download
A + ui/gfx/win/hwnd_util.cc View 6 chunks +9 lines, -9 lines 0 comments Download
A + ui/gfx/win/scoped_set_map_mode.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/gfx/win/singleton_hwnd.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + ui/gfx/win/singleton_hwnd.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/win/window_impl.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + ui/gfx/win/window_impl.cc View 1 8 chunks +9 lines, -10 lines 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/surface/accelerated_surface_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ui.gyp View 1 5 chunks +11 lines, -11 lines 0 comments Download
M ui/ui_unittests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/native_combobox_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/native_menu_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/native/native_view_host_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/native_control.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/native_control_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/aero_tooltip_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/tooltip_manager_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/win/hwnd_message_handler.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/child/webthemeengine_impl_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
7 years, 3 months ago (2013-09-12 20:39:07 UTC) #1
sky
LGTM
7 years, 3 months ago (2013-09-12 20:42:23 UTC) #2
Ben Goodger (Google)
7 years, 3 months ago (2013-09-12 20:56:34 UTC) #3
Message was sent while issue was closed. 
Committed patchset #6 manually as r222860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698