[Downloads] Open media downloads internally

[Downloads] Open media downloads internally

* Force the Custom Tab Intent to use the same package as Chrome
  when opening the media viewer.

* Open media downloads inside of the internal media viewer when
  opening the file in the notification or via the snackbar.

* Shuffle code around for creating media viewer Intents in the
  hopes of consolidating them in places that makes sense.

BUG=650448
Committed: https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac
Cr-Commit-Position: refs/heads/master@{#422624}

[gone, 2016-10-01 00:22:17]

dfalcantara@chromium.org changed reviewers:
+ qinmin@google.com, twellington@chromium.org

[qinmin, 2016-10-03 18:02:10]

Description was changed from

==========
[Downloads] Open media downloads internally

* Force the Custom Tab Intent to use the same package as Chrome
  when opening the media viewer.

* Open media downloads inside of the internal media viewer when
  opening the file in the notification or via the snackbar.

* Shuffle code around for creating media viewer Intents in the
  hopes of consolidating them in places that makes sense.

BUG=650448
==========

to

==========
[Downloads] Open media downloads internally

* Force the Custom Tab Intent to use the same package as Chrome
  when opening the media viewer.

* Open media downloads inside of the internal media viewer when
  opening the file in the notification or via the snackbar.

* Shuffle code around for creating media viewer Intents in the
  hopes of consolidating them in places that makes sense.

BUG=650448
==========

[qinmin, 2016-10-03 18:02:10]

qinmin@chromium.org changed reviewers:
+ qinmin@chromium.org
- qinmin@google.com

[qinmin, 2016-10-03 18:06:31]

https://codereview.chromium.org/2376893006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
(right):

https://codereview.chromium.org/2376893006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:996:
if (contentUri == null) return null;
shouldn't this go before setting the mimeType?

[gone, 2016-10-03 18:27:13]

https://codereview.chromium.org/2376893006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
(right):

https://codereview.chromium.org/2376893006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:996:
if (contentUri == null) return null;
On 2016/10/03 18:06:31, qinmin wrote:
> shouldn't this go before setting the mimeType?

It's not setting it, right?  Figured it would make sense to group the two
together, but I can move it downward.

[gone, 2016-10-03 18:27:54]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 18:28:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qinmin, 2016-10-03 18:28:55]

https://codereview.chromium.org/2376893006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
(right):

https://codereview.chromium.org/2376893006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:996:
if (contentUri == null) return null;
On 2016/10/03 18:27:13, dfalcantara (slow) wrote:
> On 2016/10/03 18:06:31, qinmin wrote:
> > shouldn't this go before setting the mimeType?
> 
> It's not setting it, right?  Figured it would make sense to group the two
> together, but I can move it downward.

Sorry, i mean if contentUri == null, it is just useless to get the mimeType
value as we early return here.

[gone, 2016-10-03 18:30:33]

https://codereview.chromium.org/2376893006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
(right):

https://codereview.chromium.org/2376893006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:996:
if (contentUri == null) return null;
On 2016/10/03 18:28:55, qinmin wrote:
> On 2016/10/03 18:27:13, dfalcantara (slow) wrote:
> > On 2016/10/03 18:06:31, qinmin wrote:
> > > shouldn't this go before setting the mimeType?
> > 
> > It's not setting it, right?  Figured it would make sense to group the two
> > together, but I can move it downward.
> 
> Sorry, i mean if contentUri == null, it is just useless to get the mimeType
> value as we early return here.

Yeah, moved it down for PS2.

[qinmin, 2016-10-03 18:39:36]

lgtm % comments

https://codereview.chromium.org/2376893006/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastReceiver.java
(left):

https://codereview.chromium.org/2376893006/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastReceiver.java:65:
context.startActivity(launchIntent);
this logic exists in 2 places, maybe put them into a common function

[commit-bot: I haz the power, 2016-10-03 20:43:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 20:43:12]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[gone, 2016-10-03 21:11:37]

Min, could you take another look?  I moved a bit of the logic around.

[gone, 2016-10-03 21:12:05]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 21:13:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qinmin, 2016-10-03 21:18:48]

lgtm

[commit-bot: I haz the power, 2016-10-03 22:15:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 22:15:16]

Dry run: This issue passed the CQ dry run.

[Theresa, 2016-10-03 23:34:05]

lgtm

[gone, 2016-10-04 00:18:12]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-10-04 00:19:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 00:25:10]

Description was changed from

==========
[Downloads] Open media downloads internally

* Force the Custom Tab Intent to use the same package as Chrome
  when opening the media viewer.

* Open media downloads inside of the internal media viewer when
  opening the file in the notification or via the snackbar.

* Shuffle code around for creating media viewer Intents in the
  hopes of consolidating them in places that makes sense.

BUG=650448
==========

to

==========
[Downloads] Open media downloads internally

* Force the Custom Tab Intent to use the same package as Chrome
  when opening the media viewer.

* Open media downloads inside of the internal media viewer when
  opening the file in the notification or via the snackbar.

* Shuffle code around for creating media viewer Intents in the
  hopes of consolidating them in places that makes sense.

BUG=650448
==========

[commit-bot: I haz the power, 2016-10-04 00:25:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-04 00:29:35]

Description was changed from

==========
[Downloads] Open media downloads internally

* Force the Custom Tab Intent to use the same package as Chrome
  when opening the media viewer.

* Open media downloads inside of the internal media viewer when
  opening the file in the notification or via the snackbar.

* Shuffle code around for creating media viewer Intents in the
  hopes of consolidating them in places that makes sense.

BUG=650448
==========

to

==========
[Downloads] Open media downloads internally

* Force the Custom Tab Intent to use the same package as Chrome
  when opening the media viewer.

* Open media downloads inside of the internal media viewer when
  opening the file in the notification or via the snackbar.

* Shuffle code around for creating media viewer Intents in the
  hopes of consolidating them in places that makes sense.

BUG=650448

Committed: https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac
Cr-Commit-Position: refs/heads/master@{#422624}
==========

[commit-bot: I haz the power, 2016-10-04 00:29:37]

Patchset 4 (id:??) landed as
https://crrev.com/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac
Cr-Commit-Position: refs/heads/master@{#422624}