chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java - Issue 2376893006: [Downloads] Open media downloads internally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

Issue 2376893006: [Downloads] Open media downloads internally (Closed)

Patch Set: Test changes, moving files Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java ('k') | chrome/browser/android/download/download_manager_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

index d7937e8853917de0c8a515e50ac7f61b8a29c44c..bc577f7a907e4e55de38adf77d55c9b5b93a4d72 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

@@ -245,7 +245,7 @@ public class DownloadNotificationServiceTest extends

sharedPrefs, DownloadNotificationService.PENDING_DOWNLOAD_NOTIFICATIONS);

assertEquals(3, entries.size());

- service.notifyDownloadSuccessful(guid1, "success", 100L, false);

+ service.notifyDownloadSuccessful(guid1, "/path/to/success", "success", 100L, false);

entries = DownloadManagerService.getStoredDownloadInfo(

sharedPrefs, DownloadNotificationService.PENDING_DOWNLOAD_NOTIFICATIONS);

assertEquals(2, entries.size());

@@ -270,7 +270,7 @@ public class DownloadNotificationServiceTest extends

startNotificationService();

DownloadNotificationService service = bindNotificationService();

String guid = UUID.randomUUID().toString();

- service.notifyDownloadSuccessful(guid, "test", 100L, false);

+ service.notifyDownloadSuccessful(guid, "/path/to/test", "test", 100L, false);

assertEquals(1, getService().getNotificationIds().size());

}