chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java - Issue 2376893006: [Downloads] Open media downloads internally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

Issue 2376893006: [Downloads] Open media downloads internally (Closed)

Patch Set: Test changes, moving files Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

index 2d5f7d037fcc7122d3584f7f83029c0f9f7db292..206998b8a2b0d310da95f8453b1f92c2d07069a1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

@@ -39,9 +39,8 @@ public class DownloadSnackbarController implements SnackbarManager.SnackbarContr

}

@Override

- @SuppressWarnings("unchecked")

public void onAction(Object actionData) {

- if (actionData == null) {

+ if (!(actionData instanceof ActionDataInfo)) {

DownloadManagerService.openDownloadsPage(mContext);

return;

}

@@ -51,7 +50,7 @@ public class DownloadSnackbarController implements SnackbarManager.SnackbarContr

return;

}

DownloadManagerService manager = DownloadManagerService.getDownloadManagerService(mContext);

- manager.openDownloadedContent(download.systemDownloadId);

+ manager.openDownloadedContent(download.downloadInfo, download.systemDownloadId);

if (download.notificationId != INVALID_NOTIFICATION_ID) {

NotificationManager notificationManager =

(NotificationManager) mContext.getSystemService(Context.NOTIFICATION_SERVICE);