content/browser/frame_host/navigation_controller_impl.cc - Issue 2376643002: Clean up NavigationControllerImpl::IsURLInPageNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 2376643002: Clean up NavigationControllerImpl::IsURLInPageNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_impl.h ('K') | « content/browser/frame_host/navigation_controller_impl.h ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | content/browser/frame_host/navigator_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index c0ddb1b926e0af03b8758c235c8e8a4026164be5..604846485284fde1d6ac8eab36282180a103437e 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -772,7 +772,7 @@ bool NavigationControllerImpl::PendingEntryMatchesHandle(

bool NavigationControllerImpl::RendererDidNavigate(

RenderFrameHostImpl* rfh,

const FrameHostMsg_DidCommitProvisionalLoad_Params& params,

- LoadCommittedDetails* details) {

+ LoadCommittedDetails* details, bool is_navigation_within_page) {

Charlie Reis 2016/09/27 18:51:43 Style nit: Move to next line.

is_initial_navigation_ = false;

// Save the previous state before we clobber it.

@@ -799,8 +799,7 @@ bool NavigationControllerImpl::RendererDidNavigate(

details->type = ClassifyNavigation(rfh, params);

// is_in_page must be computed before the entry gets committed.

- details->is_in_page = IsURLInPageNavigation(params.url, params.origin,

- params.was_within_same_page, rfh);

+ details->is_in_page = is_navigation_within_page;

switch (details->type) {

case NAVIGATION_TYPE_NEW_PAGE: