content/browser/frame_host/navigator_impl.cc - Issue 2376643002: Clean up NavigationControllerImpl::IsURLInPageNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 2376643002: Clean up NavigationControllerImpl::IsURLInPageNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index a25c56910565a66d44516a2022fb1c61b469ef7d..e7d1228b0f8a35a380d74574760263e11881431c 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -567,7 +567,7 @@ void NavigatorImpl::DidNavigate(

int old_entry_count = controller_->GetEntryCount();

LoadCommittedDetails details;

bool did_navigate = controller_->RendererDidNavigate(render_frame_host,

- params, &details);

+ params, &details, is_navigation_within_page);

Charlie Reis 2016/09/27 18:51:43 Style nit: Wrong indent. I recommend using "git c

// If the history length and/or offset changed, update other renderers in the

// FrameTree.

« content/browser/frame_host/navigation_controller_impl.cc ('K') | « content/browser/frame_host/navigation_controller_impl.cc ('k') | no next file » | no next file with comments »