content/browser/frame_host/navigation_controller_impl.h - Issue 2376643002: Clean up NavigationControllerImpl::IsURLInPageNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 2376643002: Clean up NavigationControllerImpl::IsURLInPageNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigation_controller_impl.h

diff --git a/content/browser/frame_host/navigation_controller_impl.h b/content/browser/frame_host/navigation_controller_impl.h

index 20bb0f6528faf151eef1d3742374bedcf9f471f1..18ae077a4d71422a45242f3f9e50a112993d202f 100644

--- a/content/browser/frame_host/navigation_controller_impl.h

+++ b/content/browser/frame_host/navigation_controller_impl.h

@@ -149,7 +149,7 @@ class CONTENT_EXPORT NavigationControllerImpl

bool RendererDidNavigate(

RenderFrameHostImpl* rfh,

const FrameHostMsg_DidCommitProvisionalLoad_Params& params,

- LoadCommittedDetails* details);

+ LoadCommittedDetails* details, bool is_navigation_within_page);

Charlie Reis 2016/09/27 18:51:43 Style nit: For function declarations, if all param

// Notifies us that we just became active. This is used by the WebContentsImpl

// so that we know to load URLs that were pending as "lazy" loads.

« AUTHORS ('K') | « AUTHORS ('k') | content/browser/frame_host/navigation_controller_impl.cc » ('j') | content/browser/frame_host/navigation_controller_impl.cc » ('J')