Issue 23766038: Thumb2 Backend: 32-bit instruction encoding methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23766038: Thumb2 Backend: 32-bit instruction encoding methods

Created:
7 years, 3 months ago by rkrithiv

Modified:
6 years, 4 months ago

Reviewers:
ulan, danno

Base URL:
HEAD^

Visibility:
Public.

More Reviews

Description

Thumb2 Backend: 32-bit instruction encoding methods This patch defines methods to encode 32-bit Thumb2 instructions. It uses the helper methods defined in https://codereview.chromium.org/24182004/. This is the 3rd patch for the Thumb2 Backend Previous patch: https://codereview.chromium.org/24182004/ Next patch: https://codereview.chromium.org/23600058/ BUG=none TEST=none

Patch Set 1 #

Total comments: 4

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+507 lines, -0 lines)			Patch
	M	src/arm/assembler-arm.h	View		8 chunks	+79 lines, -0 lines	0 comments	Download
	M	src/arm/assembler-thumb32.cc	View		1 chunk	+428 lines, -0 lines	4 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

7 years, 3 months ago (2013-09-17 08:01:54 UTC) #1

https://codereview.chromium.org/23766038/diff/1/src/arm/assembler-thumb32.cc
File src/arm/assembler-thumb32.cc (right):

https://codereview.chromium.org/23766038/diff/1/src/arm/assembler-thumb32.cc#...
src/arm/assembler-thumb32.cc:387: ASSERT(cond == al);
Why pass cond if it is constant anyway?

https://codereview.chromium.org/23766038/diff/1/src/arm/assembler-thumb32.cc#...
src/arm/assembler-thumb32.cc:396: ASSERT(cond == al);
Same here...

https://codereview.chromium.org/23766038/diff/1/src/arm/assembler-thumb32.cc#...
src/arm/assembler-thumb32.cc:406: ASSERT(cond == al);
And so on...

https://codereview.chromium.org/23766038/diff/1/src/arm/assembler-thumb32.cc#...
src/arm/assembler-thumb32.cc:579: emit32(thumb32_mode12(ASR_32_REG) |
thumb32_3reg_shift(dst, src) | s);
no ASSERT(cond == al) here?

Expand Messages | Collapse Messages