[Findit] For automatic analyses of flaky tests, run the Swarming tasks off PST peak hours.

[Findit] For automatic analyses of flaky tests, run the Swarming tasks off PST peak hours.

BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/7079bdc06bcbfd06aaf6eae0c9bd0e297fd6ed1f

[stgao, 2016-09-27 22:09:38]

stgao@chromium.org changed reviewers:
+ chanli@chromium.org, lijeffrey@chromium.org

[stgao, 2016-09-27 22:09:39]

Hi Chan & Jeff,

This CL is to make it possible to trigger Swarming tasks off PST peak hours on
workdays to identify the regression range of a flaky test.

Thanks,
Shuotao

[stgao, 2016-09-27 22:10:45]

Description was changed from

==========
[Findit] For automatic analyses of flaky tests, run the analyses off PST peak
hours of Swarming tasks.

BUG=
==========

to

==========
[Findit] For automatic analyses of flaky tests, run the Swarming tasks off PST
peak hours.

BUG=
==========

[lijeffrey, 2016-09-27 23:48:05]

lgtm with nits

https://codereview.chromium.org/2376573004/diff/1/appengine/findit/common/tim...
File appengine/findit/common/time_util.py (right):

https://codereview.chromium.org/2376573004/diff/1/appengine/findit/common/tim...
appengine/findit/common/time_util.py:54: the new timezone. If not given, default
to UTC now.
Is there a reason we don't just pass the default
date_time=GetUTCNowWithTimezone()?

i.e.
def GetDatetimeInTimezone(timezone_name, date_time=GetUTCNowWithTimezone()):
  ...

https://codereview.chromium.org/2376573004/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/flake/recursive_flake_pipeline.py (right):

https://codereview.chromium.org/2376573004/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/recursive_flake_pipeline.py:50: diff =
timedelta(hours=18 - now_at_mtv.hour,
nit: since diff is actually a random latency, why not rename random_latency?

[stgao, 2016-10-01 05:55:25]

https://codereview.chromium.org/2376573004/diff/1/appengine/findit/common/tim...
File appengine/findit/common/time_util.py (right):

https://codereview.chromium.org/2376573004/diff/1/appengine/findit/common/tim...
appengine/findit/common/time_util.py:54: the new timezone. If not given, default
to UTC now.
On 2016/09/27 23:48:05, lijeffrey wrote:
> Is there a reason we don't just pass the default
> date_time=GetUTCNowWithTimezone()?
> 
> i.e.
> def GetDatetimeInTimezone(timezone_name, date_time=GetUTCNowWithTimezone()):
>   ...

No, we can't.
Default value is created and set once and then used afterwards.
For time, it depends on when the function is called.

https://codereview.chromium.org/2376573004/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/flake/recursive_flake_pipeline.py (right):

https://codereview.chromium.org/2376573004/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/flake/recursive_flake_pipeline.py:50: diff =
timedelta(hours=18 - now_at_mtv.hour,
On 2016/09/27 23:48:05, lijeffrey wrote:
> nit: since diff is actually a random latency, why not rename random_latency?

It is not exact a random latency. It is a diff + a random. I'd keep as is.
Comment updated to avoid confusion.

[stgao, 2016-10-01 06:01:47]

Patchset #3 (id:40001) has been deleted

[stgao, 2016-10-01 06:01:53]

The CQ bit was checked by stgao@chromium.org

[stgao, 2016-10-01 06:01:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/2376573004/#ps60001
(title: "Fix nit.")

[commit-bot: I haz the power, 2016-10-01 06:01:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 06:15:54]

Description was changed from

==========
[Findit] For automatic analyses of flaky tests, run the Swarming tasks off PST
peak hours.

BUG=
==========

to

==========
[Findit] For automatic analyses of flaky tests, run the Swarming tasks off PST
peak hours.

BUG=

Committed:
https://chromium.googlesource.com/infra/infra/+/7079bdc06bcbfd06aaf6eae0c9bd0...
==========

[commit-bot: I haz the power, 2016-10-01 06:15:54]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/7079bdc06bcbfd06aaf6eae0c9bd0...