[Findit] For automatic analyses of flaky tests, run the Swarming tasks off PST peak hours.

appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+from datetime import datetime
+
+import pytz
+
 from common import constants
 from common.pipeline_wrapper import pipeline_handlers
 from model import analysis_status
 from model.flake.flake_swarming_task import FlakeSwarmingTask
 from model.flake.master_flake_analysis import DataPoint
 from model.flake.master_flake_analysis import MasterFlakeAnalysis
 from waterfall.flake import recursive_flake_pipeline
 from waterfall.flake.recursive_flake_pipeline import get_next_run
 from waterfall.flake.recursive_flake_pipeline import NextBuildNumberPipeline
 from waterfall.flake.recursive_flake_pipeline import RecursiveFlakePipeline
@@ skipping 22 matching lines @@
 
   def _GenerateDataPoints(self, pass_rates, build_numbers):
     data_points = []
     for i in range(0, len(pass_rates)):
       data_point = DataPoint()
       data_point.pass_rate = pass_rates[i]
       data_point.build_number = build_numbers[i]
       data_points.append(data_point)
     return data_points
 
+  def testGetETAToStartAnalysisWhenManuallyTriggered(self):
+    mocked_utcnow = datetime.utcnow()
+    self.MockUTCNow(mocked_utcnow)
+    self.assertEqual(mocked_utcnow,
+                     recursive_flake_pipeline._GetETAToStartAnalysis(True))
+
+  def testGetETAToStartAnalysisWhenTriggeredOnPSTWeekend(self):
+    # Sunday 1pm in PST.
+    mocked_utcnow = datetime(2016, 9, 04, 20, 0, 0, 0, pytz.utc)
+    self.MockUTCNow(mocked_utcnow)
+    self.MockUTCNowWithTimezone(mocked_utcnow)
+    self.assertEqual(mocked_utcnow,
+                     recursive_flake_pipeline._GetETAToStartAnalysis(False))
+
+  def testGetETAToStartAnalysisWhenTriggeredOffPeakHoursOnPSTWeekday(self):
+    # Tuesday 1am in PST.
+    mocked_utcnow = datetime(2016, 9, 20, 8, 0, 0, 0, pytz.utc)
+    self.MockUTCNow(mocked_utcnow)
+    self.MockUTCNowWithTimezone(mocked_utcnow)
+    self.assertEqual(mocked_utcnow,
+                     recursive_flake_pipeline._GetETAToStartAnalysis(False))
+
+  def testGetETAToStartAnalysisWhenTriggeredInPeakHoursOnPSTWeekday(self):
+    # Tuesday 1pm in PST.
+    mocked_utcnow = datetime(2016, 9, 20, 20, 0, 0, 0, pytz.utc)
+    self.MockUTCNow(mocked_utcnow)
+    self.MockUTCNowWithTimezone(mocked_utcnow)
+    eta = recursive_flake_pipeline._GetETAToStartAnalysis(False)
+    self.assertEqual(2016, eta.year)
+    self.assertEqual(9, eta.month)
+    self.assertEqual(21, eta.day)
+    self.assertEqual(1, eta.hour)
+    seconds = eta.minute * 60 + eta.second
+    self.assertTrue(seconds >= 0 and seconds <= 30 * 60)
+
   def testRecursiveFlakePipeline(self):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     run_build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'test_result_future'
     queue_name = constants.DEFAULT_QUEUE
@@ skipping 31 matching lines @@
                        run_build_number, step_name, task_id,
                        master_build_number, test_name,
                        analysis.version_number],
         expected_kwargs={})
 
     self.MockPipeline(
         recursive_flake_pipeline.NextBuildNumberPipeline,
         '',
         expected_args=[master_name, builder_name, master_build_number,
                        build_number, step_name, test_name,
-                       analysis.version_number,
-                       test_result_future, queue_name,
+                       analysis.version_number, test_result_future,
                        flakiness_algorithm_results_dict],
-        expected_kwargs={})
+        expected_kwargs={'manually_triggered': False})
 
     rfp = RecursiveFlakePipeline(
         master_name, builder_name, build_number, step_name, test_name,
         analysis.version_number, master_build_number,
-        flakiness_algorithm_results_dict=flakiness_algorithm_results_dict,
-        queue_name=queue_name)
+        flakiness_algorithm_results_dict=flakiness_algorithm_results_dict)
 
     rfp.start(queue_name=queue_name)
     self.execute_queued_tasks()
 
   def testNextBuildPipelineForNewRecursionFirstFlake(self):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
-    queue_name = constants.DEFAULT_QUEUE
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 0,
         'stabled_out': False,
         'flaked_out': False,
         'last_build_number': 0,
         'lower_boundary': None,
         'upper_boundary': None,
         'lower_boundary_result': None,
         'sequential_run_index': 0
@@ skipping 12 matching lines @@
 
     data_point = DataPoint()
     data_point.pass_rate = .08
     data_point.build_number = 100
     analysis.data_points.append(data_point)
     analysis.put()
 
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name, test_name,
-        analysis.version_number, test_result_future, queue_name,
+        analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
     self.assertEquals(flakiness_algorithm_results_dict['flakes_in_a_row'], 1)
 
   def testNextBuildPipelineForNewRecursionFirstStable(self):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
-    queue_name = constants.DEFAULT_QUEUE
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 0,
         'stabled_out': False,
         'flaked_out': False,
         'last_build_number': 0,
         'lower_boundary': None,
         'upper_boundary': None,
         'lower_boundary_result': None,
         'sequential_run_index': 0
-
     }
     self._CreateAndSaveMasterFlakeAnalysis(
         master_name, builder_name, build_number, step_name,
         test_name, status=analysis_status.PENDING
     )
     self._CreateAndSaveFlakeSwarmingTask(
         master_name, builder_name, build_number, step_name,
         test_name, status=analysis_status.COMPLETED
     )
     analysis = MasterFlakeAnalysis.GetVersion(
         master_name, builder_name, build_number, step_name, test_name)
     data_point = DataPoint()
     data_point.pass_rate = 0
     data_point.build_number = 100
     analysis.data_points.append(data_point)
     analysis.put()
 
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name,
-        test_name, analysis.version_number, test_result_future, queue_name,
+        test_name, analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
     self.assertEquals(flakiness_algorithm_results_dict['stable_in_a_row'], 1)
 
   def testNextBuildPipelineForNewRecursionFlakeInARow(self):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
-    queue_name = constants.DEFAULT_QUEUE
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 4,
         'stabled_out': False,
         'flaked_out': False,
         'last_build_number': 0,
         'lower_boundary': None,
         'upper_boundary': None,
         'lower_boundary_result': None,
         'sequential_run_index': 0
@@ skipping 11 matching lines @@
         master_name, builder_name, build_number, step_name, test_name)
     data_point = DataPoint()
     data_point.pass_rate = 0
     data_point.build_number = 100
     analysis.data_points.append(data_point)
     analysis.put()
 
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name,
-        test_name, analysis.version_number, test_result_future, queue_name,
+        test_name, analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
     self.assertEquals(flakiness_algorithm_results_dict['stabled_out'], True)
 
   def testNextBuildPipelineForNewRecursionStableInARow(self):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
-    queue_name = constants.DEFAULT_QUEUE
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 4,
         'stable_in_a_row': 0,
         'stabled_out': False,
         'flaked_out': False,
         'last_build_number': 0,
         'lower_boundary': None,
         'upper_boundary': None,
         'lower_boundary_result': None,
         'sequential_run_index': 0
@@ skipping 11 matching lines @@
         master_name, builder_name, build_number, step_name, test_name)
     data_point = DataPoint()
     data_point.pass_rate = .5
     data_point.build_number = 100
     analysis.data_points.append(data_point)
     analysis.put()
 
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name,
-        test_name, analysis.version_number, test_result_future, queue_name,
+        test_name, analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
     self.assertEquals(flakiness_algorithm_results_dict['flaked_out'], True)
 
   def testNextBuildPipelineForNewRecursionLessThanLastBuildNumber(self):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
-    queue_name = constants.DEFAULT_QUEUE
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 0,
         'stabled_out': False,
         'flaked_out': False,
         'last_build_number': 200,
         'lower_boundary': None,
         'upper_boundary': None,
         'lower_boundary_result': None,
         'sequential_run_index': 0
     }
     self._CreateAndSaveMasterFlakeAnalysis(
         master_name, builder_name, build_number, step_name,
         test_name, status=analysis_status.PENDING
     )
     self._CreateAndSaveFlakeSwarmingTask(
         master_name, builder_name, build_number, step_name,
         test_name, status=analysis_status.COMPLETED
     )
     analysis = MasterFlakeAnalysis.GetVersion(
         master_name, builder_name, build_number, step_name, test_name)
     data_point = DataPoint()
     data_point.pass_rate = .5
     data_point.build_number = 100
     analysis.data_points.append(data_point)
     analysis.put()
 
     queue_name = {'x': False}
-    def my_mocked_run(arg1, queue_name):  # pylint: disable=unused-argument
+    def my_mocked_run(*_, **__):
       queue_name['x'] = True  # pragma: no cover
 
     self.mock(
         recursive_flake_pipeline.RecursiveFlakePipeline, 'start', my_mocked_run)
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name, test_name,
-        analysis.version_number, test_result_future, queue_name,
+        analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
     self.assertFalse(queue_name['x'])
 
   def testNextBuildPipelineForFailedSwarmingTask(self):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
-    queue_name = constants.DEFAULT_QUEUE
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 0,
         'stabled_out': False,
         'flaked_out': False,
         'last_build_number': 0,
         'lower_boundary': None,
         'upper_boundary': None,
         'lower_boundary_result': None,
         'sequential_run_index': 0
 
     }
     self._CreateAndSaveMasterFlakeAnalysis(
         master_name, builder_name, build_number, step_name,
         test_name, status=analysis_status.PENDING
     )
     self._CreateAndSaveFlakeSwarmingTask(
         master_name, builder_name, build_number, step_name,
         test_name, status=analysis_status.ERROR
     )
     analysis = MasterFlakeAnalysis.GetVersion(
         master_name, builder_name, build_number, step_name, test_name)
     data_point = DataPoint()
     data_point.pass_rate = .5
     data_point.build_number = 100
     analysis.data_points.append(data_point)
     analysis.put()
 
     queue_name = {'x': False}
-    def my_mocked_run(arg1, queue_name):  # pylint: disable=unused-argument
+    def my_mocked_run(*_, **__):
       queue_name['x'] = True  # pragma: no cover
 
     self.mock(
         recursive_flake_pipeline.RecursiveFlakePipeline, 'start', my_mocked_run)
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name, test_name, 1,
-        test_result_future, queue_name, flakiness_algorithm_results_dict)
+        test_result_future, flakiness_algorithm_results_dict)
     self.assertFalse(queue_name['x'])
 
   def testNextBuildPipelineForNewRecursionStabledFlakedOut(self):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
@@ skipping 19 matching lines @@
     )
     analysis = MasterFlakeAnalysis.GetVersion(
         master_name, builder_name, build_number, step_name, test_name)
     data_point = DataPoint()
     data_point.pass_rate = .5
     data_point.build_number = 100
     analysis.data_points.append(data_point)
     analysis.put()
 
     queue_name = {'x': False}
-    def my_mocked_run(arg1, queue_name):  # pylint: disable=unused-argument
+    def my_mocked_run(*_, **__):
       queue_name['x'] = True  # pragma: no cover
 
     self.mock(
         recursive_flake_pipeline.RecursiveFlakePipeline, 'start', my_mocked_run)
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name, test_name,
-        analysis.version_number, test_result_future, queue_name,
+        analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
     self.assertTrue(queue_name['x'])
 
   def testGetNextRunSetStableLowerBoundary(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 100
     step_name = 's'
     test_name = 't'
     self._CreateAndSaveMasterFlakeAnalysis(
@@ skipping 193 matching lines @@
     self.assertEqual(analysis.suspected_flake_build_number, None)
 
   def testNextBuildPipelineStabledOutFlakedOutFirstTime(self):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 100
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
-    queue_name = constants.DEFAULT_QUEUE
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 0,
         'stabled_out': True,
         'flaked_out': True,
         'last_build_number': 0,
         'lower_boundary': 100,
         'upper_boundary': 110,
         'lower_boundary_result': None,
         'sequential_run_index': 0
@@ skipping 11 matching lines @@
         master_name, builder_name, build_number, step_name, test_name)
     data_point = DataPoint()
     data_point.pass_rate = 1
     data_point.build_number = 100
     analysis.data_points.append(data_point)
     analysis.put()
 
     NextBuildNumberPipeline.run(
         NextBuildNumberPipeline(), master_name, builder_name,
         master_build_number, build_number, step_name, test_name,
-        analysis.version_number, test_result_future, queue_name,
+        analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
     self.assertEquals(
         flakiness_algorithm_results_dict['sequential_run_index'], 1)
 
   def testNextBuildWhenTestNotExistingAfterStableInARow(self):
     master = MasterFlakeAnalysis.Create('m', 'b', 100, 's', 't')
     master.data_points = self._GenerateDataPoints(
         pass_rates=[0.8, 1.0, 1.0, -1], build_numbers=[100, 80, 70, 60])
 
     flakiness_algorithm_results_dict = {
@@ skipping 41 matching lines @@
                      flakiness_algorithm_results_dict['lower_boundary_result'])
 
   def testNextBuildNumberIsLargerThanStartingBuildNumber(self):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 60
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
-    queue_name = constants.DEFAULT_QUEUE
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 3,
         'stabled_out': False,
         'flaked_out': False,
         'last_build_number': 0,
         'lower_boundary': None,
         'upper_boundary': None,
         'lower_boundary_result': None,
         'sequential_run_index': 0
     }
     self._CreateAndSaveMasterFlakeAnalysis(
         master_name, builder_name, master_build_number, step_name,
         test_name, status=analysis_status.RUNNING)
     self._CreateAndSaveFlakeSwarmingTask(
         master_name, builder_name, build_number, step_name,
         test_name, status=analysis_status.COMPLETED)
 
     analysis = MasterFlakeAnalysis.GetVersion(
         master_name, builder_name, master_build_number, step_name, test_name)
     analysis.data_points = self._GenerateDataPoints(
         pass_rates=[1.0, 1.0, 1.0, -1], build_numbers=[100, 80, 70, 60])
     analysis.put()
 
     pipeline = NextBuildNumberPipeline()
     pipeline.run(
         master_name, builder_name,
         master_build_number, build_number, step_name, test_name,
-        analysis.version_number, test_result_future, queue_name,
+        analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
 
     analysis = MasterFlakeAnalysis.GetVersion(
         master_name, builder_name, master_build_number, step_name, test_name)
     self.assertEqual(analysis_status.COMPLETED, analysis.status)
 
   def testNextBuildNumberIsSmallerThanLastBuildNumber(self):
     master_name = 'm'
     builder_name = 'b'
     master_build_number = 100
     build_number = 60
     step_name = 's'
     test_name = 't'
     test_result_future = 'trf'
-    queue_name = constants.DEFAULT_QUEUE
     flakiness_algorithm_results_dict = {
         'flakes_in_a_row': 0,
         'stable_in_a_row': 3,
         'stabled_out': False,
         'flaked_out': False,
         'last_build_number': 59,
         'lower_boundary': None,
         'upper_boundary': None,
         'lower_boundary_result': None,
         'sequential_run_index': 0
     }
     analysis = MasterFlakeAnalysis.Create(
         master_name, builder_name, master_build_number, step_name, test_name)
     analysis.data_points = self._GenerateDataPoints(
         pass_rates=[1.0, 1.0, 1.0, 1.0], build_numbers=[100, 80, 70, 60])
     analysis.status = analysis_status.RUNNING
     analysis.Save()
 
     self._CreateAndSaveFlakeSwarmingTask(
         master_name, builder_name, build_number, step_name,
         test_name, status=analysis_status.COMPLETED)
 
     pipeline = NextBuildNumberPipeline()
     pipeline.run(
         master_name, builder_name,
         master_build_number, build_number, step_name, test_name,
-        analysis.version_number, test_result_future, queue_name,
+        analysis.version_number, test_result_future,
         flakiness_algorithm_results_dict)
 
     analysis = MasterFlakeAnalysis.GetVersion(
         master_name, builder_name, master_build_number, step_name, test_name)
     self.assertEqual(analysis_status.COMPLETED, analysis.status)