Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2274)

Unified Diff: appengine/findit/waterfall/flake/initialize_flake_pipeline.py

Issue 2376573004: [Findit] For automatic analyses of flaky tests, run the Swarming tasks off PST peak hours. (Closed)
Patch Set: Fix nit. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/third_party/gae-pytz ('k') | appengine/findit/waterfall/flake/recursive_flake_pipeline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/flake/initialize_flake_pipeline.py
diff --git a/appengine/findit/waterfall/flake/initialize_flake_pipeline.py b/appengine/findit/waterfall/flake/initialize_flake_pipeline.py
index 84746724ddf28cc6d00d0a23d93d56041baf5a03..8a4ef283a872088e7e56c60e1d0cf4592f415d0c 100644
--- a/appengine/findit/waterfall/flake/initialize_flake_pipeline.py
+++ b/appengine/findit/waterfall/flake/initialize_flake_pipeline.py
@@ -53,6 +53,7 @@ def NeedANewAnalysis(
# Unused arguments - pylint: disable=W0612, W0613
def ScheduleAnalysisIfNeeded(master_name, builder_name, build_number, step_name,
test_name, allow_new_analysis=False, force=False,
+ manually_triggered=False,
queue_name=constants.DEFAULT_QUEUE):
"""Schedules an analysis if needed and returns the MasterFlakeAnalysis.
@@ -67,6 +68,8 @@ def ScheduleAnalysisIfNeeded(master_name, builder_name, build_number, step_name,
test_name (str): The single test we are checking
allow_new_analysis (bool): Indicate whether a new analysis is allowed.
force (bool): Indicate whether to force a rerun of current analysis.
+ manually_triggered (bool): True if the analysis is from manual request, like
+ by a Chromium sheriff.
queue_name (str): The App Engine queue to run the analysis.
Returns:
@@ -115,10 +118,11 @@ def ScheduleAnalysisIfNeeded(master_name, builder_name, build_number, step_name,
pipeline_job = RecursiveFlakePipeline(
master_name, builder_name, build_number, step_name, test_name,
version_number, master_build_number=build_number,
- flakiness_algorithm_results_dict=flakiness_algorithm_results_dict)
+ flakiness_algorithm_results_dict=flakiness_algorithm_results_dict,
+ manually_triggered=manually_triggered)
pipeline_job.target = appengine_util.GetTargetNameForModule(
constants.WATERFALL_BACKEND)
- pipeline_job.start(queue_name=queue_name)
+ pipeline_job.StartOffPSTPeakHours(queue_name=queue_name)
return MasterFlakeAnalysis.GetVersion(
master_name, builder_name, build_number, step_name, test_name,
version=version_number)
« no previous file with comments | « appengine/findit/third_party/gae-pytz ('k') | appengine/findit/waterfall/flake/recursive_flake_pipeline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698