Disable Ctrl+Shift+P on Chrome OS

chrome/browser/ui/browser_command_controller.cc

Index: chrome/browser/ui/browser_command_controller.cc
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index c6c2df58e8479b9893ad163e3752236404b47824..a7908bb0b1645624dc24b147311e2584660b2b19 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -445,9 +445,13 @@ void BrowserCommandController::ExecuteCommandWithDisposition(
 
 #if defined(ENABLE_BASIC_PRINTING)
     case IDC_BASIC_PRINT:
+#if defined(OS_CHROMEOS)
+      NOTREACHED();  // System dialog is disabled for Chrome OS.
+#else
       content::RecordAction(base::UserMetricsAction("Accel_Advanced_Print"));
       BasicPrint(browser_);
       break;
+#endif  // OS_CHROMEOS
 #endif  // ENABLE_BASIC_PRINTING
 
     case IDC_SAVE_CREDIT_CARD_FOR_PAGE:
@@ -1097,8 +1101,12 @@ void BrowserCommandController::UpdatePrintingState() {
   bool print_enabled = CanPrint(browser_);
   command_updater_.UpdateCommandEnabled(IDC_PRINT, print_enabled);
 #if defined(ENABLE_BASIC_PRINTING)
+#if defined(OS_CHROMEOS)
+  command_updater_.UpdateCommandEnabled(IDC_BASIC_PRINT, false);

[Lei Zhang, 2016/10/03 18:33:03]

Why not just make CanBasicPrint() return false?

[skau, 2016/10/03 21:52:04]

I wasn't sure if it was used elsewhere.  I've double checked and it looks
appropriate.  

+#else
   command_updater_.UpdateCommandEnabled(IDC_BASIC_PRINT,
                                         CanBasicPrint(browser_));
+#endif  // OS_CHROMEOS
 #endif  // ENABLE_BASIC_PRINTING
 }