Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

Issue 2376193006: Disable Ctrl+Shift+P on Chrome OS (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/browser_command_controller.cc ('K') | « chrome/browser/ui/browser_command_controller.cc ('k') | printing/printing_context_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/print_preview/print_preview_handler.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
index 3fc1a13edeadf563ae804989cb5b7852475140a3..b4586c18b4f918bbbbc64e1518d9cde4c4c16d03 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
@@ -1148,6 +1148,9 @@ void PrintPreviewHandler::HandleManageCloudPrint(
#if defined(ENABLE_BASIC_PRINTING)
Lei Zhang 2016/10/03 18:33:03 Why not just change this so HandleShowSystemDialog
skau 2016/10/03 21:52:05 Done.
void PrintPreviewHandler::HandleShowSystemDialog(
const base::ListValue* /*args*/) {
+#if defined(OS_CHROMEOS)
+ NOTREACHED();
+#else
ReportStats();
ReportUserActionHistogram(FALLBACK_TO_ADVANCED_SETTINGS_DIALOG);
@@ -1163,7 +1166,9 @@ void PrintPreviewHandler::HandleShowSystemDialog(
// Cancel the pending preview request if exists.
print_preview_ui()->OnCancelPendingPreviewRequest();
+#endif // OS_CHROMEOS
}
+
#endif // ENABLE_BASIC_PRINTING
void PrintPreviewHandler::HandleManagePrinters(
« chrome/browser/ui/browser_command_controller.cc ('K') | « chrome/browser/ui/browser_command_controller.cc ('k') | printing/printing_context_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698