Disable Ctrl+Shift+P on Chrome OS

chrome/browser/ui/browser_command_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_command_controller.h"
 
 #include <stddef.h>
 
 #include <string>
 
@@ skipping 427 matching lines @@
       break;
     case IDC_EMAIL_PAGE_LOCATION:
       EmailPageLocation(browser_);
       break;
     case IDC_PRINT:
       Print(browser_);
       break;
 
 #if defined(ENABLE_BASIC_PRINTING)
     case IDC_BASIC_PRINT:
+#if defined(OS_CHROMEOS)
+      NOTREACHED();  // System dialog is disabled for Chrome OS.
+#else
       content::RecordAction(base::UserMetricsAction("Accel_Advanced_Print"));
       BasicPrint(browser_);
       break;
+#endif  // OS_CHROMEOS
 #endif  // ENABLE_BASIC_PRINTING
 
     case IDC_SAVE_CREDIT_CARD_FOR_PAGE:
       SaveCreditCard(browser_);
       break;
     case IDC_TRANSLATE_PAGE:
       Translate(browser_);
       break;
     case IDC_MANAGE_PASSWORDS_FOR_PAGE:
       ManagePasswordsForPage(browser_);
@@ skipping 629 matching lines @@
   command_updater_.UpdateCommandEnabled(IDC_TOGGLE_FULLSCREEN_TOOLBAR,
                                         fullscreen_enabled);
 
   UpdateCommandsForBookmarkBar();
 }
 
 void BrowserCommandController::UpdatePrintingState() {
   bool print_enabled = CanPrint(browser_);
   command_updater_.UpdateCommandEnabled(IDC_PRINT, print_enabled);
 #if defined(ENABLE_BASIC_PRINTING)
+#if defined(OS_CHROMEOS)
+  command_updater_.UpdateCommandEnabled(IDC_BASIC_PRINT, false);

[Lei Zhang, 2016/10/03 18:33:03]

Why not just make CanBasicPrint() return false?

[skau, 2016/10/03 21:52:04]

I wasn't sure if it was used elsewhere.  I've double checked and it looks
appropriate.  

+#else
   command_updater_.UpdateCommandEnabled(IDC_BASIC_PRINT,
                                         CanBasicPrint(browser_));
+#endif  // OS_CHROMEOS
 #endif  // ENABLE_BASIC_PRINTING
 }
 
 void BrowserCommandController::UpdateSaveAsState() {
   command_updater_.UpdateCommandEnabled(IDC_SAVE_PAGE, CanSavePage(browser_));
 }
 
 void BrowserCommandController::UpdateShowSyncState(bool show_main_ui) {
   command_updater_.UpdateCommandEnabled(
       IDC_SHOW_SYNC_SETUP, show_main_ui && pref_signin_allowed_.GetValue());
@@ skipping 61 matching lines @@
 
 BrowserWindow* BrowserCommandController::window() {
   return browser_->window();
 }
 
 Profile* BrowserCommandController::profile() {
   return browser_->profile();
 }
 
 }  // namespace chrome