Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2375743002: [Merge M54] aw: Fix FBO restore in webview functor (Closed)

Created:
4 years, 2 months ago by boliu
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge M54] aw: Fix FBO restore in webview functor See bug for problem description. Have AwGLSurface get the current FBO directly from ScopedAppGLStateRestore. Conceptually ScopedAppGLStateRestore would be in the ui/gl layer, so having AwGLSurface access it directly isn't really a problem. Seems a lot cleaner than dependency injection which involves crossing many (conceptual) layers anyway. Global is bad, but any time GL executes without ScopedAppGLStateRestore would indicate bigger bugs, so in practice should be ok. BUG=649738 Review-Url: https://codereview.chromium.org/2360423003 Cr-Commit-Position: refs/heads/master@{#420913} (cherry picked from commit cf4731774e0d1110244be09be8cb456f83f5ce44) Committed: https://chromium.googlesource.com/chromium/src/+/ea2934399b34646b59c0e5dc5793b52847ff69b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -72 lines) Patch
M android_webview/browser/aw_gl_surface.h View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/browser/aw_gl_surface.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M android_webview/browser/hardware_renderer.h View 2 chunks +1 line, -4 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M android_webview/browser/parent_output_surface.h View 2 chunks +1 line, -4 lines 0 comments Download
M android_webview/browser/parent_output_surface.cc View 4 chunks +21 lines, -19 lines 0 comments Download
M android_webview/browser/render_thread_manager.cc View 2 chunks +1 line, -11 lines 0 comments Download
M android_webview/browser/scoped_app_gl_state_restore.h View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/scoped_app_gl_state_restore.cc View 2 chunks +13 lines, -1 line 0 comments Download
M android_webview/browser/surfaces_instance.h View 2 chunks +1 line, -4 lines 0 comments Download
M android_webview/browser/surfaces_instance.cc View 4 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
boliu
4 years, 2 months ago (2016-09-27 20:58:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ea2934399b34646b59c0e5dc5793b52847ff69b6.

Powered by Google App Engine
This is Rietveld 408576698