Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2375383005: Prune CreateVisibleSelectionDeprecated from unit test files (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, dtapuska+blinkwatch_chromium.org, nzolghadr+blinkwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune CreateVisibleSelectionDeprecated from unit test files This patch also adds DCHECKs to createVisibleSelection to prevent callers from passing null base and non-null extent, which does not make sense. BUG=651373 Committed: https://crrev.com/b84e284987d122603226db600a398a9cbe235f62 Cr-Commit-Position: refs/heads/master@{#422049}

Patch Set 1 #

Messages

Total messages: 14 (9 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-09-30 06:44:25 UTC) #8
tkent
lgtm
4 years, 2 months ago (2016-09-30 06:52:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375383005/1
4 years, 2 months ago (2016-09-30 06:53:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 06:59:05 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 07:00:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b84e284987d122603226db600a398a9cbe235f62
Cr-Commit-Position: refs/heads/master@{#422049}

Powered by Google App Engine
This is Rietveld 408576698