third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp - Issue 2375383005: Prune CreateVisibleSelectionDeprecated from unit test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

Issue 2375383005: Prune CreateVisibleSelectionDeprecated from unit test files (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp ('k') | third_party/WebKit/Source/core/input/EventHandlerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

index d44d8f54a1520cf0f2f3381dca48ffc0270fc1df..f0a72aabda51b27abf62bdc4ac09b3ef688aa55c 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

@@ -203,10 +203,11 @@ TEST_F(HTMLTextFormControlElementTest, SpellCheckDoesNotCauseUpdateLayout)

HTMLInputElement* input = toHTMLInputElement(document().getElementById("input"));

input->focus();

input->setValue("Hello, input field");

+ document().updateStyleAndLayout();

VisibleSelection oldSelection = document().frame()->selection().selection();

Position newPosition(input->innerEditorElement()->firstChild(), 3);

- VisibleSelection newSelection = createVisibleSelectionDeprecated(newPosition, TextAffinity::Downstream);

+ VisibleSelection newSelection = createVisibleSelection(newPosition, TextAffinity::Downstream);

document().frame()->selection().setSelection(newSelection, FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle | FrameSelection::DoNotUpdateAppearance);

ASSERT_EQ(3, input->selectionStart());