Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2375383005: Prune CreateVisibleSelectionDeprecated from unit test files (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index 756c5470228adf5f54ccbc89355861dc351778bd..f63e2c9621d7c4b342b83bceff064fa1c696444f 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -172,6 +172,7 @@ VisibleSelection createVisibleSelection(const Position& base, const Position& ex
{
DCHECK(!needsLayoutTreeUpdate(base));
DCHECK(!needsLayoutTreeUpdate(extent));
+ DCHECK(base.isNotNull() || extent.isNull());
return VisibleSelection::create(base, extent, affinity, isDirectional);
}
@@ -191,6 +192,7 @@ VisibleSelection createVisibleSelection(const VisiblePosition& base, const Visib
{
DCHECK(base.isValid());
DCHECK(extent.isValid());
+ DCHECK(base.isNotNull() || extent.isNull());
return VisibleSelection::create(base.deepEquivalent(), extent.deepEquivalent(), base.affinity(), isDirectional);
}
@@ -211,6 +213,7 @@ VisibleSelectionInFlatTree createVisibleSelection(const PositionInFlatTree& base
{
DCHECK(!needsLayoutTreeUpdate(base));
DCHECK(!needsLayoutTreeUpdate(extent));
+ DCHECK(base.isNotNull() || extent.isNull());
return VisibleSelectionInFlatTree::create(base, extent, affinity, isDirectional);
}
@@ -230,6 +233,7 @@ VisibleSelectionInFlatTree createVisibleSelection(const VisiblePositionInFlatTre
{
DCHECK(base.isValid());
DCHECK(extent.isValid());
+ DCHECK(base.isNotNull() || extent.isNull());
return VisibleSelectionInFlatTree::create(base.deepEquivalent(), extent.deepEquivalent(), base.affinity(), isDirectional);
}

Powered by Google App Engine
This is Rietveld 408576698