[tracing] Fix loss of focus in empty heap details breakdown view tab

[tracing] Fix loss of focus in empty heap details breakdown view tab

The breakdown view (right sub-pane) of the "Heap details" UI will now
keep focus even if the currently displayed node cannot be expanded any
further.

BUG=catapult:#2750

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/52f7f68535f401d7c97c53f07822c552ff56e422

[petrcermak, 2016-09-28 17:21:36]

petrcermak@chromium.org changed reviewers:
+ primiano@chromium.org

[petrcermak, 2016-09-28 17:21:37]

PTAL.

Thanks,
Petr

[petrcermak, 2016-10-03 07:37:12]

hjd: PTAL.

Thanks,
Petr

[hjd, 2016-10-03 09:19:31]

hjd@chromium.org changed reviewers:
+ hjd@chromium.org

[hjd, 2016-10-03 09:19:32]

one typo nit, Collumn -> Column otherwise LGTM

https://codereview.chromium.org/2375143002/diff/1/tracing/tracing/ui/analysis...
File tracing/tracing/ui/analysis/memory_dump_heap_details_breakdown_view.html
(right):

https://codereview.chromium.org/2375143002/diff/1/tracing/tracing/ui/analysis...
tracing/tracing/ui/analysis/memory_dump_heap_details_breakdown_view.html:37:
function EmptyFillerCollumn() {}
s/Collumn/Column/g

[petrcermak, 2016-10-03 09:25:31]

Thanks for your comment :-)

https://codereview.chromium.org/2375143002/diff/1/tracing/tracing/ui/analysis...
File tracing/tracing/ui/analysis/memory_dump_heap_details_breakdown_view.html
(right):

https://codereview.chromium.org/2375143002/diff/1/tracing/tracing/ui/analysis...
tracing/tracing/ui/analysis/memory_dump_heap_details_breakdown_view.html:37:
function EmptyFillerCollumn() {}
On 2016/10/03 09:19:32, hjd wrote:
> s/Collumn/Column/g

Done.

[petrcermak, 2016-10-03 09:25:35]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-10-03 09:25:35]

The patchset sent to the CQ was uploaded after l-g-t-m from hjd@chromium.org
Link to the patchset: https://codereview.chromium.org/2375143002/#ps20001
(title: "s/Collumn/Column/g")

[commit-bot: I haz the power, 2016-10-03 09:25:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 09:51:10]

Description was changed from

==========
[tracing] Fix loss of focus in empty heap details breakdown view tab

The breakdown view (right sub-pane) of the "Heap details" UI will now
keep focus even if the currently displayed node cannot be expanded any
further.

BUG=catapult:#2750
==========

to

==========
[tracing] Fix loss of focus in empty heap details breakdown view tab

The breakdown view (right sub-pane) of the "Heap details" UI will now
keep focus even if the currently displayed node cannot be expanded any
further.

BUG=catapult:#2750

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-10-03 09:51:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...