Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: tracing/tracing/ui/analysis/memory_dump_heap_details_breakdown_view.html

Issue 2375143002: [tracing] Fix loss of focus in empty heap details breakdown view tab (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: s/Collumn/Column/g Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/analysis/memory_dump_heap_details_breakdown_view.html
diff --git a/tracing/tracing/ui/analysis/memory_dump_heap_details_breakdown_view.html b/tracing/tracing/ui/analysis/memory_dump_heap_details_breakdown_view.html
index c98f9840ee6e07d44c90be1491817464f85eeeb9..b0ffa6f9d61d67d26c038fd79eb7ea7e6cc4966c 100644
--- a/tracing/tracing/ui/analysis/memory_dump_heap_details_breakdown_view.html
+++ b/tracing/tracing/ui/analysis/memory_dump_heap_details_breakdown_view.html
@@ -23,17 +23,8 @@ found in the LICENSE file.
<dom-module id='tr-ui-a-memory-dump-heap-details-breakdown-view-tab'>
<template>
- <style>
- #info_text {
- padding: 8px;
- color: #666;
- font-style: italic;
- text-align: center;
- }
- </style>
<tr-v-ui-scalar-context-controller></tr-v-ui-scalar-context-controller>
<tr-ui-b-table id="table"></tr-ui-b-table>
- <div id="info_text"></div>
</template>
</dom-module>
@@ -42,6 +33,17 @@ found in the LICENSE file.
tr.exportTo('tr.ui.analysis', function() {
+ /** @constructor */
+ function EmptyFillerColumn() {}
+
+ EmptyFillerColumn.prototype = {
+ title: '',
+
+ value: function() {
+ return '';
+ },
+ };
+
Polymer({
is: 'tr-ui-a-memory-dump-heap-details-breakdown-view',
behaviors: [tr.ui.analysis.RebuildableBehavior],
@@ -194,28 +196,18 @@ tr.exportTo('tr.ui.analysis', function() {
},
onRebuild_: function() {
- if (this.nodes_ === undefined || this.nodes_.length === 0) {
- this.$.table.clear();
- this.$.table.style.display = 'none';
- this.$.info_text.style.display = 'block';
- this.$.info_text.textContent = 'Cannot break down by ' +
- this.dimensionLabel_.toLowerCase() + ' any further.';
- return;
- }
-
- this.$.table.style.display = 'block';
- this.$.info_text.style.display = 'none';
- this.$.info_text.textContent = '';
-
this.$.table.selectionMode = tr.ui.b.TableFormat.SelectionMode.ROW;
- this.$.table.tableRows = this.nodes_;
- this.$.table.tableColumns = this.createColumns_(this.nodes_);
+ this.$.table.emptyValue = 'Cannot break down by ' +
+ this.dimensionLabel_.toLowerCase() + ' any further.';
+ var rows = this.nodes_ || [];
+ this.$.table.tableRows = rows;
+ this.$.table.tableColumns = this.createColumns_(rows);
this.$.table.rebuild();
},
createColumns_: function(rows) {
var titleColumn = new tr.ui.analysis.HeapDetailsTitleColumn(
- this.tabLabel);
+ this.dimensionLabel_);
titleColumn.width = '200px';
var numericColumns = tr.ui.analysis.MemoryColumn.fromRows(rows, {
@@ -224,6 +216,9 @@ tr.exportTo('tr.ui.analysis', function() {
rules: tr.ui.analysis.HEAP_DETAILS_COLUMN_RULES,
shouldSetContextGroup: true
});
+ if (numericColumns.length === 0) {
+ numericColumns.push(new EmptyFillerColumn());
+ }
tr.ui.analysis.MemoryColumn.spaceEqually(numericColumns);
var columns = [titleColumn].concat(numericColumns);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698