Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 23748003: Cleanup Semaphore class. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Cleanup Semaphore class. Drop the previous Semaphore class from platform files. Add new Semaphore class using the new TimeDelta class for the WaitFor() operation. Consistently assert correct behaviour for the different implementations. Improve test coverage of the Semaphore class. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16473

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : mach_timespec cannot represent negative time deltas. #

Patch Set 4 : Make sure semantic of Semaphore::WaitFor() is consistent across all platforms. #

Patch Set 5 : Visual Studio does not support V8_OVERRIDE on destructors. #

Patch Set 6 : Damn broken Rietveld! #

Total comments: 2

Patch Set 7 : REBASE and nit. #

Patch Set 8 : Build fix for Mac OS X. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+752 lines, -753 lines) Patch
M src/api.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M src/d8.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/d8.cc View 5 chunks +4 lines, -8 lines 0 comments Download
M src/d8-debug.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/d8-debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/debug.cc View 6 chunks +11 lines, -19 lines 0 comments Download
M src/debug-agent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/debug-agent.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M src/isolate.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/log.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/marking-thread.h View 1 chunk +4 lines, -9 lines 0 comments Download
M src/marking-thread.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M src/optimizing-compiler-thread.h View 3 chunks +5 lines, -11 lines 0 comments Download
M src/optimizing-compiler-thread.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M src/platform.h View 5 chunks +2 lines, -60 lines 0 comments Download
M src/platform-cygwin.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M src/platform-freebsd.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M src/platform-macos.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M src/platform-openbsd.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M src/platform-solaris.cc View 1 chunk +0 lines, -78 lines 0 comments Download
M src/platform-win32.cc View 1 chunk +0 lines, -43 lines 0 comments Download
A src/platform/semaphore.h View 1 chunk +126 lines, -0 lines 0 comments Download
A src/platform/semaphore.cc View 1 2 3 1 chunk +214 lines, -0 lines 0 comments Download
M src/platform/time.h View 3 chunks +10 lines, -0 lines 0 comments Download
M src/platform/time.cc View 1 2 3 4 5 6 7 2 chunks +54 lines, -0 lines 0 comments Download
M src/profile-generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.cc View 5 chunks +9 lines, -10 lines 0 comments Download
M src/sweeper-thread.h View 2 chunks +4 lines, -9 lines 0 comments Download
M src/sweeper-thread.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/cctest.h View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/cctest.gyp View 2 chunks +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 20 chunks +26 lines, -31 lines 0 comments Download
M test/cctest/test-circular-queue.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M test/cctest/test-debug.cc View 8 chunks +10 lines, -13 lines 0 comments Download
D test/cctest/test-lock.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M test/cctest/test-lockers.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M test/cctest/test-log.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A test/cctest/test-semaphore.cc View 1 2 3 4 5 6 1 chunk +152 lines, -0 lines 0 comments Download
M test/cctest/test-sockets.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-time.cc View 2 chunks +29 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Benedikt Meurer
Same for Semaphore, PTAL
7 years, 3 months ago (2013-08-30 14:37:44 UTC) #1
Michael Starzinger
Latest patch-set is busted. Can you upload it again?
7 years, 3 months ago (2013-09-02 09:04:35 UTC) #2
Benedikt Meurer
On 2013/09/02 09:04:35, Michael Starzinger wrote: > Latest patch-set is busted. Can you upload it ...
7 years, 3 months ago (2013-09-02 09:07:43 UTC) #3
Michael Starzinger
LGTM. https://codereview.chromium.org/23748003/diff/24001/test/cctest/test-semaphore.cc File test/cctest/test-semaphore.cc (right): https://codereview.chromium.org/23748003/diff/24001/test/cctest/test-semaphore.cc#newcode28 test/cctest/test-semaphore.cc:28: // Tests of the TokenLock class from lock.h ...
7 years, 3 months ago (2013-09-02 11:45:31 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/23748003/diff/24001/test/cctest/test-semaphore.cc File test/cctest/test-semaphore.cc (right): https://codereview.chromium.org/23748003/diff/24001/test/cctest/test-semaphore.cc#newcode28 test/cctest/test-semaphore.cc:28: // Tests of the TokenLock class from lock.h On ...
7 years, 3 months ago (2013-09-02 12:04:31 UTC) #5
Benedikt Meurer
7 years, 3 months ago (2013-09-02 12:26:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #8 manually as r16473 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698