test/cctest/test-threads.cc - Issue 23748003: Cleanup Semaphore class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-threads.cc

Issue 23748003: Cleanup Semaphore class. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Build fix for Mac OS X. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-threads.cc

diff --git a/test/cctest/test-threads.cc b/test/cctest/test-threads.cc

index a35a88dc26c6d576828db0cf9126262ffb956062..6cc5f523386dcea9ab4cd54a45eb009f36d06b5f 100644

--- a/test/cctest/test-threads.cc

+++ b/test/cctest/test-threads.cc

@@ -180,7 +180,7 @@ TEST(ThreadIdValidation) {

const int kNThreads = 100;

i::List<ThreadIdValidationThread*> threads(kNThreads);

i::List<i::ThreadId> refs(kNThreads);

- i::Semaphore* semaphore = i::OS::CreateSemaphore(0);

+ i::Semaphore* semaphore = new i::Semaphore(0);

ThreadIdValidationThread* prev = NULL;

for (int i = kNThreads - 1; i >= 0; i--) {

ThreadIdValidationThread* newThread =

« no previous file with comments | « test/cctest/test-thread-termination.cc ('k') | test/cctest/test-time.cc » ('j') | no next file with comments »