Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2376153004: Move core/fpdfapi/include to core/fpdfapi (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -147 lines) Patch
M BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/cpdf_modulemgr.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/cpdf_modulemgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cpdf_pagerendercontext.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/cpdf_pagerendercontext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/GB1/cmaps_gb1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Japan1/cmaps_japan1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/Korea1/cmaps_korea1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_cidfont.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_font.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorspace.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_image.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 2 chunks +1 line, -1 line 0 comments Download
D core/fpdfapi/include/cpdf_modulemgr.h View 1 chunk +0 lines, -76 lines 0 comments Download
D core/fpdfapi/include/cpdf_pagerendercontext.h View 1 chunk +0 lines, -31 lines 0 comments Download
M fpdfsdk/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_ext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_progressive.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfdoc_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfeditimg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfeditimg_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2382763002 Patch 20001

Dependent Patchsets:

Issue 2374383003 Patch 20001

Messages

Total messages: 12 (8 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-09-29 14:53:48 UTC) #4
Tom Sepez
LGTM % bots
4 years, 2 months ago (2016-09-29 18:18:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376153004/20001
4 years, 2 months ago (2016-09-29 19:32:17 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 19:49:21 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/39c62fd528854eb4606b8f1917a777532b04...

Powered by Google App Engine
This is Rietveld 408576698