Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2374333002: Disable flaky MD Settings tests on Windows (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam, dpapad
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky MD Settings tests on Windows These tests have been timing out on Win7 Tests (dbg)(1). BUG=651296 TBR=dpapad@chromium.org Committed: https://crrev.com/4b73fe91b1242219730280be352207c1afd6b238 Cr-Commit-Position: refs/heads/master@{#421775}

Patch Set 1 #

Patch Set 2 : Don't redefine the macro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
tsergeant
4 years, 2 months ago (2016-09-29 05:27:12 UTC) #6
Dan Beam
lgtm
4 years, 2 months ago (2016-09-29 05:49:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374333002/20001
4 years, 2 months ago (2016-09-29 06:27:00 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/38869)
4 years, 2 months ago (2016-09-29 07:08:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374333002/20001
4 years, 2 months ago (2016-09-29 07:14:07 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-29 07:56:57 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 07:58:24 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b73fe91b1242219730280be352207c1afd6b238
Cr-Commit-Position: refs/heads/master@{#421775}

Powered by Google App Engine
This is Rietveld 408576698