Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc

Issue 2374333002: Disable flaky MD Settings tests on Windows (Closed)
Patch Set: Don't redefine the macro Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "chrome/browser/ui/browser.h" 7 #include "chrome/browser/ui/browser.h"
8 #include "chrome/browser/ui/browser_commands.h" 8 #include "chrome/browser/ui/browser_commands.h"
9 #include "chrome/browser/ui/tabs/tab_strip_model.h" 9 #include "chrome/browser/ui/tabs/tab_strip_model.h"
10 #include "chrome/common/url_constants.h" 10 #include "chrome/common/url_constants.h"
(...skipping 11 matching lines...) Expand all
22 22
23 using ui_test_utils::NavigateToURL; 23 using ui_test_utils::NavigateToURL;
24 using content::WaitForLoadStop; 24 using content::WaitForLoadStop;
25 25
26 IN_PROC_BROWSER_TEST_F(MdSettingsUITest, ViewSourceDoesntCrash) { 26 IN_PROC_BROWSER_TEST_F(MdSettingsUITest, ViewSourceDoesntCrash) {
27 NavigateToURL(browser(), 27 NavigateToURL(browser(),
28 GURL(content::kViewSourceScheme + std::string(":") + 28 GURL(content::kViewSourceScheme + std::string(":") +
29 chrome::kChromeUIMdSettingsURL)); 29 chrome::kChromeUIMdSettingsURL));
30 } 30 }
31 31
32 // May not complete on memory bots. TODO(dbeam): investigate and fix. 32 // May not complete on memory and Windows debug bots. TODO(dbeam): investigate
33 // See https://crbug.com/558434 and https://crbug.com/620370. 33 // and fix. See https://crbug.com/558434, https://crbug.com/620370 and
34 #if defined(MEMORY_SANITIZER) 34 // https://crbug.com/651296.
35 #if defined(MEMORY_SANITIZER) || defined(OS_WIN)
35 #define MAYBE_BackForwardDoesntCrash DISABLED_BackForwardDoesntCrash 36 #define MAYBE_BackForwardDoesntCrash DISABLED_BackForwardDoesntCrash
36 #else 37 #else
37 #define MAYBE_BackForwardDoesntCrash BackForwardDoesntCrash 38 #define MAYBE_BackForwardDoesntCrash BackForwardDoesntCrash
38 #endif 39 #endif
39 40
40 IN_PROC_BROWSER_TEST_F(MdSettingsUITest, MAYBE_BackForwardDoesntCrash) { 41 IN_PROC_BROWSER_TEST_F(MdSettingsUITest, MAYBE_BackForwardDoesntCrash) {
41 NavigateToURL(browser(), GURL(chrome::kChromeUIMdSettingsURL)); 42 NavigateToURL(browser(), GURL(chrome::kChromeUIMdSettingsURL));
42 43
43 NavigateToURL(browser(), GURL(chrome::kChromeUINewTabURL)); 44 NavigateToURL(browser(), GURL(chrome::kChromeUINewTabURL));
44 45
(...skipping 11 matching lines...) Expand all
56 ->GetActiveWebContents() 57 ->GetActiveWebContents()
57 ->GetWebUI() 58 ->GetWebUI()
58 ->GetHandlersForTesting(); 59 ->GetHandlersForTesting();
59 60
60 for (content::WebUIMessageHandler* handler : handlers) { 61 for (content::WebUIMessageHandler* handler : handlers) {
61 handler->AllowJavascriptForTesting(); 62 handler->AllowJavascriptForTesting();
62 handler->DisallowJavascript(); 63 handler->DisallowJavascript();
63 handler->AllowJavascriptForTesting(); 64 handler->AllowJavascriptForTesting();
64 } 65 }
65 } 66 }
OLDNEW
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698