Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc

Issue 2374333002: Disable flaky MD Settings tests on Windows (Closed)
Patch Set: Don't redefine the macro Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc b/chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc
index 8ab348ea5ec0b00b7b90b3ef3bc01f92241a6152..8614ed948a06b1cc645357b95e026b62cbe06380 100644
--- a/chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc
@@ -29,9 +29,10 @@ IN_PROC_BROWSER_TEST_F(MdSettingsUITest, ViewSourceDoesntCrash) {
chrome::kChromeUIMdSettingsURL));
}
-// May not complete on memory bots. TODO(dbeam): investigate and fix.
-// See https://crbug.com/558434 and https://crbug.com/620370.
-#if defined(MEMORY_SANITIZER)
+// May not complete on memory and Windows debug bots. TODO(dbeam): investigate
+// and fix. See https://crbug.com/558434, https://crbug.com/620370 and
+// https://crbug.com/651296.
+#if defined(MEMORY_SANITIZER) || defined(OS_WIN)
#define MAYBE_BackForwardDoesntCrash DISABLED_BackForwardDoesntCrash
#else
#define MAYBE_BackForwardDoesntCrash BackForwardDoesntCrash
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698