MD Settings: Migrating settings-dropdown-menu to use native select.

MD Settings: Migrating settings-dropdown-menu to use native select.

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c9604416470e1bcb85be4adf15dc605efea29ded
Cr-Commit-Position: refs/heads/master@{#422955}

[dpapad, 2016-09-30 23:03:54]

Description was changed from

==========
MD Settings: Migrating settings-dropdown-menu to use native select.

BUG=651513
==========

to

==========
MD Settings: Migrating settings-dropdown-menu to use native select.

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-09-30 23:09:13]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 23:09:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-10-01 00:09:12]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 00:09:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-10-01 00:32:41]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-10-01 00:32:42]

FYI, I removed the 'label' Polymer property from <settings-dropdown-menu> since
it was not used anywhere.

[commit-bot: I haz the power, 2016-10-01 02:20:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 02:20:13]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-10-04 00:37:16]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 00:37:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-10-04 01:36:35]

Removed usage of Polymer.dom.flush(). I was also able to simplify the somewhat
confusing checkSetup_ and updateSelected_ observer methods (there is now only
one observer method).

[Dan Beam, 2016-10-04 01:59:45]

lgtm

https://codereview.chromium.org/2374253012/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_dropdown_menu.js
(right):

https://codereview.chromium.org/2374253012/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_dropdown_menu.js:35: * @type
{!DropdownMenuOptionList}
{?

https://codereview.chromium.org/2374253012/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/dropdown_menu_tests.js (right):

https://codereview.chromium.org/2374253012/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/dropdown_menu_tests.js:18: function
waitForFlush() {
nit: waitUntilDropdownRendered() or something less generic

[commit-bot: I haz the power, 2016-10-04 02:06:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 02:06:10]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-10-04 20:38:12]

https://codereview.chromium.org/2374253012/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_dropdown_menu.js
(right):

https://codereview.chromium.org/2374253012/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_dropdown_menu.js:35: * @type
{!DropdownMenuOptionList}
On 2016/10/04 at 01:59:45, Dan Beam wrote:
> {?

Done.

https://codereview.chromium.org/2374253012/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/dropdown_menu_tests.js (right):

https://codereview.chromium.org/2374253012/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/dropdown_menu_tests.js:18: function
waitForFlush() {
On 2016/10/04 at 01:59:45, Dan Beam wrote:
> nit: waitUntilDropdownRendered() or something less generic

Done.

[dpapad, 2016-10-04 20:40:06]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-10-04 20:40:06]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2374253012/#ps80001
(title: "Resolve conflicts, address nits.")

[commit-bot: I haz the power, 2016-10-04 20:41:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 22:12:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-04 22:14:06]

Description was changed from

==========
MD Settings: Migrating settings-dropdown-menu to use native select.

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Migrating settings-dropdown-menu to use native select.

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c9604416470e1bcb85be4adf15dc605efea29ded
Cr-Commit-Position: refs/heads/master@{#422955}
==========

[commit-bot: I haz the power, 2016-10-04 22:14:08]

Patchset 5 (id:??) landed as
https://crrev.com/c9604416470e1bcb85be4adf15dc605efea29ded
Cr-Commit-Position: refs/heads/master@{#422955}