MD Settings: Style native <select> down arrow.

MD Settings: Style native <select> down arrow.

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9d324d4772dccf8c90af719c74b74732c38518f8
Cr-Commit-Position: refs/heads/master@{#423009}

[dpapad, 2016-10-04 21:37:33]

Description was changed from

==========
MD Settings: Style native <select> down arrow.

BUG=651513
==========

to

==========
MD Settings: Style native <select> down arrow.

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-10-04 21:39:25]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-10-04 21:40:55]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-10-04 21:40:56]

This is my first attempt to get a styled downwards arrow for <select>,
http://imgur.com/a/gZZbJ. I created a new svg from scratch, which allowed me to
not need to use transform/translate within the SVG (we can probably simplify
arrow_right.svg in a similar way).

[Dan Beam, 2016-10-04 22:12:33]

but wait, I thought we talked about .md-select as a class, not continuing to
actually style all <select> tags directly?

https://codereview.chromium.org/2384273005/diff/10004/chrome/browser/resource...
File chrome/browser/resources/settings/md_select_css.html (right):

https://codereview.chromium.org/2384273005/diff/10004/chrome/browser/resource...
chrome/browser/resources/settings/md_select_css.html:28: background-size: 0.9em;
can this be

select {
  background: url(images/arrow_down.svg) 97% 70% no-repeat;
  background-size: 0.9em;
}

:host-context([dir=rtl]) select {
  background-position-x: 97%;
}

?

[dpapad, 2016-10-04 22:26:34]

>but wait, I thought we talked about .md-select as a class, not continuing to
actually style all <select> tags directly?

Had not realized you were asking for .md-select class (otherwise would have done
it at https://codereview.chromium.org/2393463002). Anyway, done now.

https://codereview.chromium.org/2384273005/diff/10004/chrome/browser/resource...
File chrome/browser/resources/settings/md_select_css.html (right):

https://codereview.chromium.org/2384273005/diff/10004/chrome/browser/resource...
chrome/browser/resources/settings/md_select_css.html:28: background-size: 0.9em;
On 2016/10/04 at 22:12:33, Dan Beam wrote:
> can this be
> 
> select {
>   background: url(images/arrow_down.svg) 97% 70% no-repeat;
>   background-size: 0.9em;
> }
> 
> :host-context([dir=rtl]) select {
>   background-position-x: 97%;
> }
> 
> ?

Done.

[Dan Beam, 2016-10-04 22:29:14]

lgtm

https://codereview.chromium.org/2384273005/diff/30001/chrome/browser/resource...
File chrome/browser/resources/settings/md_select_css.html (right):

https://codereview.chromium.org/2384273005/diff/30001/chrome/browser/resource...
chrome/browser/resources/settings/md_select_css.html:42: .select-wrapper {
should this be md-select-wrapper?

https://codereview.chromium.org/2384273005/diff/30001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
(right):

https://codereview.chromium.org/2384273005/diff/30001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html:79:
<select class="md-select address-column long" value="[[countryCode_]]"
wrap

[dpapad, 2016-10-04 22:48:09]

https://codereview.chromium.org/2384273005/diff/30001/chrome/browser/resource...
File chrome/browser/resources/settings/md_select_css.html (right):

https://codereview.chromium.org/2384273005/diff/30001/chrome/browser/resource...
chrome/browser/resources/settings/md_select_css.html:42: .select-wrapper {
On 2016/10/04 at 22:29:14, Dan Beam wrote:
> should this be md-select-wrapper?

Done. Also renamed select-underline accordingly.

https://codereview.chromium.org/2384273005/diff/30001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
(right):

https://codereview.chromium.org/2384273005/diff/30001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html:79:
<select class="md-select address-column long" value="[[countryCode_]]"
On 2016/10/04 at 22:29:14, Dan Beam wrote:
> wrap

Done.

[dpapad, 2016-10-04 22:49:34]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-10-04 22:49:35]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2384273005/#ps90001
(title: "md-select-underline")

[commit-bot: I haz the power, 2016-10-04 22:50:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 23:58:04]

Committed patchset #5 (id:90001)

[commit-bot: I haz the power, 2016-10-05 00:01:41]

Description was changed from

==========
MD Settings: Style native <select> down arrow.

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Style native <select> down arrow.

BUG=651513
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9d324d4772dccf8c90af719c74b74732c38518f8
Cr-Commit-Position: refs/heads/master@{#423009}
==========

[commit-bot: I haz the power, 2016-10-05 00:01:42]

Patchset 5 (id:??) landed as
https://crrev.com/9d324d4772dccf8c90af719c74b74732c38518f8
Cr-Commit-Position: refs/heads/master@{#423009}