Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/browser/resources/settings/controls/settings_dropdown_menu.html

Issue 2374253012: MD Settings: Migrating settings-dropdown-menu to use native select. (Closed)
Patch Set: Resolve conflicts, address nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/controls/settings_dropdown_menu.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu-light.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-lis tbox.html">
4 <link rel="import" href="/controls/pref_control_behavior.html"> 2 <link rel="import" href="/controls/pref_control_behavior.html">
5 <link rel="import" href="/i18n_setup.html"> 3 <link rel="import" href="/i18n_setup.html">
4 <link rel="import" href="/md_select_css.html">
6 <link rel="import" href="/prefs/pref_util.html"> 5 <link rel="import" href="/prefs/pref_util.html">
7 <link rel="import" href="/settings_shared_css.html"> 6 <link rel="import" href="/settings_shared_css.html">
8 7
9 <dom-module id="settings-dropdown-menu"> 8 <dom-module id="settings-dropdown-menu">
10 <template> 9 <template>
11 <style include="settings-shared"></style> 10 <style include="settings-shared md-select"></style>
12 <paper-dropdown-menu-light id="dropdownMenu" label="[[menuLabel_]]" 11 <div class="select-wrapper">
13 on-iron-select="onSelect_" no-label-float vertical-align="auto" 12 <select id="dropdownMenu" on-change="onChange_" value="[[selected_]]"
14 disabled="[[shouldDisableMenu_(disabled, menuOptions.*)]]"> 13 disabled="[[shouldDisableMenu_(disabled, menuOptions)]]">
15 <paper-listbox class="dropdown-content" selected="{{selected_}}" 14 <template is="dom-repeat" items="[[menuOptions]]">
16 attr-for-selected="data-value"> 15 <option value="[[item.value]]" data-value$="[[item.value]]">
17 <template is="dom-repeat" items="[[menuOptions]]" initial-count="5">
18 <button class="dropdown-item" role="option"
19 data-value$="[[item.value]]">
20 [[item.name]] 16 [[item.name]]
21 </button> 17 </option>
22 </template> 18 </template>
23 <button class="dropdown-item" role="option" 19 <option value="[[notFoundValue_]]"
24 data-value$="[[notFoundValue_]]"
25 hidden$="[[!isSelectedNotFound_(selected_)]]"> 20 hidden$="[[!isSelectedNotFound_(selected_)]]">
26 $i18n{custom} 21 $i18n{custom}
27 </button> 22 </option>
28 </paper-listbox> 23 </select>
29 </paper-dropdown-menu-light> 24 <span class="select-underline"></span>
25 </div>
30 </template> 26 </template>
31 <script src="settings_dropdown_menu.js"></script> 27 <script src="settings_dropdown_menu.js"></script>
32 </dom-module> 28 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/controls/settings_dropdown_menu.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698