Issue 2374223003: Sync MDP: reimplement value conversions ontop of visitors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2374223003: Sync MDP: reimplement value conversions ontop of visitors

Created:
4 years, 2 months ago by Dmitry Skiba

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews, sync-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Sync MDP: reimplement value conversions ontop of visitors BUG=649065

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9155 lines, -1237 lines)			Patch
M	components/sync/BUILD.gn	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	components/sync/driver/about_sync_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/sync/engine/cycle/sync_cycle_snapshot.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	components/sync/engine/events/configure_get_updates_request_event.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	components/sync/protocol/proto_compare_value_conversions_unittest.cc	View	1 chunk	+160 lines, -0 lines	0 comments	Download
M	components/sync/protocol/proto_enum_conversions.h	View	1 chunk	+22 lines, -22 lines	0 comments	Download
M	components/sync/protocol/proto_enum_conversions.cc	View	22 chunks	+27 lines, -22 lines	0 comments	Download
M	components/sync/protocol/proto_enum_conversions_unittest.cc	View	1 chunk	+17 lines, -25 lines	0 comments	Download
A +	components/sync/protocol/proto_old_value_conversions.h	View	3 chunks	+5 lines, -3 lines	0 comments	Download
A +	components/sync/protocol/proto_old_value_conversions.cc	View	24 chunks	+27 lines, -25 lines	0 comments	Download
A	components/sync/protocol/proto_unittest_serialized_data.h	View	1 chunk	+386 lines, -0 lines	0 comments	Download
A	components/sync/protocol/proto_unittest_serialized_data.cc	View	1 chunk	+7405 lines, -0 lines	0 comments	Download
M	components/sync/protocol/proto_value_conversions.h	View	7 chunks	+1 line, -19 lines	0 comments	Download
M	components/sync/protocol/proto_value_conversions.cc	View	1 chunk	+205 lines, -1116 lines	0 comments	Download
M	components/sync/protocol/proto_value_conversions_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	components/sync/protocol/proto_visitors.h	View	1 chunk	+890 lines, -0 lines	0 comments	Download

Dependent Patchsets:

Issue 2382443006 Patch 1

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Dmitry Skiba

4 years, 2 months ago (2016-09-29 21:57:55 UTC) #1

Description was changed from

==========
Sync MDP: reimplement value conversions ontop of visitors
==========

to

==========
Sync MDP: reimplement value conversions ontop of visitors

BUG=649065
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages