Sync MDP: reimplement value conversions ontop of visitors

components/sync/protocol/proto_value_conversions_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Keep this file in sync with the .proto files in this directory.
 
 #include "components/sync/protocol/proto_value_conversions.h"
 
 #include <memory>
 #include <string>
@@ skipping 98 matching lines @@
 }
 
 TEST_F(ProtoValueConversionsTest, AppNotificationToValue) {
   TestSpecificsToValue(AppNotificationToValue);
 }
 
 TEST_F(ProtoValueConversionsTest, AppSettingSpecificsToValue) {
   sync_pb::AppNotificationSettings specifics;
   specifics.set_disabled(true);
   specifics.set_oauth_client_id("some_id_value");
-  std::unique_ptr<base::DictionaryValue> value(AppSettingsToValue(specifics));
+  std::unique_ptr<base::DictionaryValue>
+      value(AppNotificationSettingsToValue(specifics));
   EXPECT_FALSE(value->empty());
   bool disabled_value = false;
   std::string oauth_client_id_value;
   EXPECT_TRUE(value->GetBoolean("disabled", &disabled_value));
   EXPECT_EQ(true, disabled_value);
   EXPECT_TRUE(value->GetString("oauth_client_id", &oauth_client_id_value));
   EXPECT_EQ("some_id_value", oauth_client_id_value);
 }
 
 TEST_F(ProtoValueConversionsTest, AppSpecificsToValue) {
@@ skipping 286 matching lines @@
   EXPECT_FALSE(ValueHasSpecifics(*(value_without_specifics.get()),
                                  "get_updates.entries"));
 }
 
 TEST_F(ProtoValueConversionsTest, AttachmentIdProtoToValue) {
   TestSpecificsToValue(AttachmentIdProtoToValue);
 }
 
 }  // namespace
 }  // namespace syncer