Sync MDP: reimplement value conversions ontop of visitors

components/sync/protocol/proto_old_value_conversions.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Keep this file in sync with the .proto files in this directory.
 
-#ifndef COMPONENTS_SYNC_PROTOCOL_PROTO_VALUE_CONVERSIONS_H_
-#define COMPONENTS_SYNC_PROTOCOL_PROTO_VALUE_CONVERSIONS_H_
+#ifndef COMPONENTS_SYNC_PROTOCOL_PROTO_OLD_VALUE_CONVERSIONS_H_
+#define COMPONENTS_SYNC_PROTOCOL_PROTO_OLD_VALUE_CONVERSIONS_H_
 
 #include <memory>
 
 namespace base {
 class DictionaryValue;
 }
 
 namespace sync_pb {
 class AppListSpecifics;
 class AppNotification;
@@ skipping 68 matching lines @@
 // Utility functions to convert sync protocol buffers to dictionaries.
 // Each protocol field is mapped to a key of the same name.  Repeated
 // fields are mapped to array values and sub-messages are mapped to
 // sub-dictionary values.
 //
 // TODO(akalin): Add has_* information.
 //
 // TODO(akalin): Improve enum support.
 
 namespace syncer {
+namespace old {
 
 // Ownership of all returned DictionaryValues are transferred to the
 // caller.
 
 // TODO(akalin): Perhaps extend this to decrypt?
 std::unique_ptr<base::DictionaryValue> EncryptedDataToValue(
     const sync_pb::EncryptedData& encrypted_data);
 
 // Sub-protocol of AppListSpecifics.
 std::unique_ptr<base::DictionaryValue> AppListSpecificsToValue(
@@ skipping 205 matching lines @@
 
 std::unique_ptr<base::DictionaryValue> ClientConfigParamsToValue(
     const sync_pb::ClientConfigParams& proto);
 
 std::unique_ptr<base::DictionaryValue> AttachmentIdProtoToValue(
     const sync_pb::AttachmentIdProto& proto);
 
 std::unique_ptr<base::DictionaryValue> EntityMetadataToValue(
     const sync_pb::EntityMetadata& metadata);
 
+}  // namespace old
 }  // namespace syncer
 
-#endif  // COMPONENTS_SYNC_PROTOCOL_PROTO_VALUE_CONVERSIONS_H_
+#endif  // COMPONENTS_SYNC_PROTOCOL_PROTO_OLD_VALUE_CONVERSIONS_H_